PARQUET-359: Removes existing _common_metadata when fails to write summary files #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
+1 |
Member
|
there's a typo in the description. Could you fix it? PARQUE_T_-359 |
liancheng
changed the title
Contributor
Author
|
@julienledem Oops, thanks. Fixed. |
Member
|
thanks @liancheng. Could you rebase your branch as well? |
Contributor
Author
|
@julienledem Actually I just realized that #277 has already addressed this issue. So I'm closing this one. Thanks for the review! |
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When appending Parquet files to a directory containing existing Parquet data together with their summary files, new data may contain different but compatible schema from existing data. Ideally, summary files should be updated and contain a merged version of schema. However,
ParquetOutputCommittermay fail to write summary files if new files and old files contain conflicting user-defined metadata. In this case, we should remove existing_metadataas well as_common_metadata.