PARQUET-373: Fix flaky MemoryManager tests.#269
Closed
rdblue wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
rdblue
force-pushed
the
PARQUET-373-fix-flaky-mem-manager-tests
branch
from
d927d76 to
5e8afc3
Compare
Contributor
Author
|
@spena could you take a look at this? The MemoryManager is in support of Hive. |
There was a problem hiding this comment.
Are we deleting this file after it's being used? Mabye a file.deleteOnExit() here would help to avoid leaving temporary files after tests.
Contributor
Author
There was a problem hiding this comment.
Removing this file is done by the TemporaryFolder. Because we use the Rule annotation, it is created and cleaned up by the framework.
rdblue
force-pushed
the
PARQUET-373-fix-flaky-mem-manager-tests
branch
from
5e8afc3 to
b88dd3d
Compare
|
Thanks for the explanation. The code looks good to me. |
Contributor
Author
|
@isnotinvain could you take a look? Lots of PR tests are failing because of this so I'd like to get it in. |
Contributor
There was a problem hiding this comment.
nitpick, but:
if (!file.delete()) { throw new RuntimeException("Could not delete file: " + file); }
Contributor
|
+1, one minor comment |
rdblue
force-pushed
the
PARQUET-373-fix-flaky-mem-manager-tests
branch
from
b88dd3d to
1b55889
Compare
Contributor
Author
|
Thanks for reviewing this, @isnotinvain! |
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jul 13, 2016
Author: Ryan Blue <blue@apache.org> Closes apache#269 from rdblue/PARQUET-373-fix-flaky-mem-manager-tests and squashes the following commits: 1b55889 [Ryan Blue] PARQUET-373: Fix flaky MemoryManager tests.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
Author: Ryan Blue <blue@apache.org> Closes apache#269 from rdblue/PARQUET-373-fix-flaky-mem-manager-tests and squashes the following commits: 1b55889 [Ryan Blue] PARQUET-373: Fix flaky MemoryManager tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.