Skip to content

PARQUET-387: Improve NPE message when avro arrays contain null. #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rdblue wants to merge 2 commits into from
Closed

PARQUET-387: Improve NPE message when avro arrays contain null. #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6b6bd8
PARQUET-387: Improve NPE message when avro arrays contain null.
rdblue Nov 25, 2015
39d3c83
PARQUET-387: Update test case to verify help message.
rdblue Nov 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 34 additions & 4 deletions parquet-avro/src/main/java/org/apache/parquet/avro/AvroWriteSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,8 +452,24 @@ public void writeCollection(GroupType schema, Schema avroSchema,
Collection<?> array) {
if (array.size() > 0) {
recordConsumer.startField(OLD_LIST_REPEATED_NAME, 0);
for (Object elt : array) {
writeValue(schema.getType(0), avroSchema.getElementType(), elt);
try {
for (Object elt : array) {
writeValue(schema.getType(0), avroSchema.getElementType(), elt);
}
} catch (NullPointerException e) {
// find the null element and throw a better error message
int i = 0;
for (Object elt : array) {
if (elt == null) {
throw new NullPointerException(
"Array contains a null element at " + i + "\n" +
"Set parquet.avro.write-old-list-structure=false to turn " +
"on support for arrays with null elements.");
}
i += 1;
}
// no element was null, throw the original exception
throw e;
}
recordConsumer.endField(OLD_LIST_REPEATED_NAME, 0);
}
Expand All @@ -464,8 +480,22 @@ protected void writeObjectArray(GroupType type, Schema schema,
Object[] array) {
if (array.length > 0) {
recordConsumer.startField(OLD_LIST_REPEATED_NAME, 0);
for (Object element : array) {
writeValue(type.getType(0), schema.getElementType(), element);
try {
for (Object element : array) {
writeValue(type.getType(0), schema.getElementType(), element);
}
} catch (NullPointerException e) {
// find the null element and throw a better error message
for (int i = 0; i < array.length; i += 1) {
if (array[i] == null) {
throw new NullPointerException(
"Array contains a null element at " + i + "\n" +
"Set parquet.avro.write-old-list-structure=false to turn " +
"on support for arrays with null elements.");
}
}
// no element was null, throw the original exception
throw e;
}
recordConsumer.endField(OLD_LIST_REPEATED_NAME, 0);
}
Expand Down
4 changes: 3 additions & 1 deletion parquet-avro/src/test/java/org/apache/parquet/avro/TestReadWriteOldListBehavior.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
import org.apache.parquet.io.api.Binary;
import org.apache.parquet.io.api.RecordConsumer;
import org.apache.parquet.schema.MessageTypeParser;
import org.junit.Assert;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
Expand Down Expand Up @@ -347,7 +348,8 @@ public void testArrayWithNullValues() throws Exception {
writer.write(record);
fail("Should not succeed writing an array with null values");
} catch (Exception e) {
// expected
Assert.assertTrue("Error message should provide context and help",
e.getMessage().contains("parquet.avro.write-old-list-structure"));
} finally {
writer.close();
}
Expand Down