PARQUET-421: Fix mismatch of javadoc names and method parameters in m... #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule encoding, column, and hadoop
Contributor
|
Looks good to me, @proflin. Thanks for fixing docs issues! Could you add a Parquet JIRA issue for this and add it to this PR's summary? We only merge PRs that start like "PARQUET-NNN: Fix mismatch of javadoc names and method parameters". |
lw-lin
changed the title
lw-lin
changed the title
Contributor
Author
|
JIRA ticket added & this PR's title updated. |
lw-lin
deleted the
Minor--Fix-the-mismatch-of-the-parameters-and-their-doc-comments-in-module-encoding,-column,-and-hadoop
branch
piyushnarang
pushed a commit
to piyushnarang/parquet-mr
that referenced
this pull request
Jun 15, 2016
…odule encoding, column, and hadoop Codes change now and then, but some corresponding doc comments are left out. This PR fixes only the doc comments that should have been changed. It should be OK, since none codes are touched. @rdblue could you take a look please? Cheers. Author: proflin <proflin.me@gmail.com> Closes apache#307 from proflin/Minor--Fix-the-mismatch-of-the-parameters-and-their-doc-comments-in-module-encoding,-column,-and-hadoop and squashes the following commits: 34c7b01 [proflin] Minor: Fix the mismatch of the parameters and their doc comments in module encoding, column, and hadoop
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
…odule encoding, column, and hadoop Codes change now and then, but some corresponding doc comments are left out. This PR fixes only the doc comments that should have been changed. It should be OK, since none codes are touched. @rdblue could you take a look please? Cheers. Author: proflin <proflin.me@gmail.com> Closes apache#307 from proflin/Minor--Fix-the-mismatch-of-the-parameters-and-their-doc-comments-in-module-encoding,-column,-and-hadoop and squashes the following commits: 34c7b01 [proflin] Minor: Fix the mismatch of the parameters and their doc comments in module encoding, column, and hadoop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…odule encoding, column, and hadoop
Codes change now and then, but some corresponding doc comments are left out.
This PR fixes only the doc comments that should have been changed. It should be OK, since none codes are touched.
@rdblue could you take a look please? Cheers.