PARQUET-432: Complete a todo for method ColumnDescriptor.compareTo() #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lw-lin
changed the title
lw-lin
changed the title
Contributor
Author
|
@rdblue @liancheng would you mind to take a look at this? It's a fairly small, self-explanatory change. Thanks! |
Contributor
There was a problem hiding this comment.
Newline at the end of file please.
Contributor
Author
There was a problem hiding this comment.
Addressed the issue. Thanks!
Contributor
|
Looks good to me except for one minor formatting issue. |
Contributor
Author
|
Updates: added a new line at the end of file. |
Contributor
|
+1 pending Jenkins |
Contributor
|
Thanks for fixing this! Merging to master. |
piyushnarang
pushed a commit
to piyushnarang/parquet-mr
that referenced
this pull request
Jun 15, 2016
The ticket proposes to consider the case *path.length < o.path.length* in, for method ColumnDescriptor.compareTo(). Author: proflin <proflin.me@gmail.com> Closes apache#314 from proflin/PARQUET-432 and squashes the following commits: 80ba94b [proflin] Addresses PR comments 6ccd00f [proflin] Revert Updates a4d2a4a [proflin] PARQUET-432: Complete a todo in method ColumnDescriptor.compareTo() 694b76b [proflin] Updates
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jul 13, 2016
The ticket proposes to consider the case *path.length < o.path.length* in, for method ColumnDescriptor.compareTo(). Author: proflin <proflin.me@gmail.com> Closes apache#314 from proflin/PARQUET-432 and squashes the following commits: 80ba94b [proflin] Addresses PR comments 6ccd00f [proflin] Revert Updates a4d2a4a [proflin] PARQUET-432: Complete a todo in method ColumnDescriptor.compareTo() 694b76b [proflin] Updates
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
The ticket proposes to consider the case *path.length < o.path.length* in, for method ColumnDescriptor.compareTo(). Author: proflin <proflin.me@gmail.com> Closes apache#314 from proflin/PARQUET-432 and squashes the following commits: 80ba94b [proflin] Addresses PR comments 6ccd00f [proflin] Revert Updates a4d2a4a [proflin] PARQUET-432: Complete a todo in method ColumnDescriptor.compareTo() 694b76b [proflin] Updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ticket proposes to consider the case path.length < o.path.length in, for method ColumnDescriptor.compareTo().