PARQUET-495: Fix mismatches in Types class comments #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 I'm merging this to master. Thanks! |
piyushnarang
pushed a commit
to piyushnarang/parquet-mr
that referenced
this pull request
Jun 15, 2016
To produce
> required group User {
required int64 id;
**optional** binary email (UTF8);
}
we should do:
>
Types.requiredGroup()
.required(INT64).named("id")
.~~**required** (BINARY).as(UTF8).named("email")~~
.**optional** (BINARY).as(UTF8).named("email")
.named("User")
@rdblue @liancheng would you mind taking a look at it when you have time? Thanks!
Author: Liwei Lin <proflin.me@gmail.com>
Author: proflin <proflin.me@gmail.com>
Closes apache#317 from proflin/PARQUET-495--Fix-mismatches-in-Types-class-comments and squashes the following commits:
f26d57d [Liwei Lin] PARQUET-495: Fix mismatches in Types class comments
839b458 [proflin] Merge remote-tracking branch 'refs/remotes/apache/master'
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
To produce
> required group User {
required int64 id;
**optional** binary email (UTF8);
}
we should do:
>
Types.requiredGroup()
.required(INT64).named("id")
.~~**required** (BINARY).as(UTF8).named("email")~~
.**optional** (BINARY).as(UTF8).named("email")
.named("User")
@rdblue @liancheng would you mind taking a look at it when you have time? Thanks!
Author: Liwei Lin <proflin.me@gmail.com>
Author: proflin <proflin.me@gmail.com>
Closes apache#317 from proflin/PARQUET-495--Fix-mismatches-in-Types-class-comments and squashes the following commits:
f26d57d [Liwei Lin] PARQUET-495: Fix mismatches in Types class comments
839b458 [proflin] Merge remote-tracking branch 'refs/remotes/apache/master'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To produce
we should do:
@rdblue @liancheng would you mind taking a look at it when you have time? Thanks!