Skip to content

PARQUET-511: Integer overflow when counting values in column. #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
goreckm wants to merge 2 commits into from
Closed

PARQUET-511: Integer overflow when counting values in column. #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7334be2
PARQUET-511: Integer overflow when counting values in column.
goreckm Feb 5, 2016
d224815
enhancing exception message
goreckm Mar 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnReaderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public double getDouble() {
private int dictionaryId;

private long endOfPageValueCount;
private int readValues = 0;
private long readValues = 0;
private int pageValueCount = 0;

private final PrimitiveConverter converter;
Expand Down Expand Up @@ -352,8 +352,8 @@ public ColumnReaderImpl(ColumnDescriptor path, PageReader pageReader, PrimitiveC
this.dictionary = null;
}
this.totalValueCount = pageReader.getTotalValueCount();
if (totalValueCount == 0) {
throw new ParquetDecodingException("totalValueCount == 0");
if (totalValueCount <= 0) {
throw new ParquetDecodingException("totalValueCount '" + totalValueCount + "' <= 0");
}
consume();
}
Expand Down
2 changes: 1 addition & 1 deletion parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ static final class ColumnChunkPageReader implements PageReader {
this.decompressor = decompressor;
this.compressedPages = new LinkedList<DataPage>(compressedPages);
this.compressedDictionaryPage = compressedDictionaryPage;
int count = 0;
long count = 0;
for (DataPage p : compressedPages) {
count += p.getValueCount();
}
Expand Down