PARQUET-560: Synchronize writes to the finishCalled variable #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@nezihyigitbasi, looks like the compatibility check is catching this change. It's not a binary incompatible change according to the Oracle docs, so it should be safe to add a temporary exclusion for this in the root pom. Could you add that and then I'll merge? Thanks! |
Member
|
I guess another option is to make it a synchronized(this) block inside the method |
nezihyigitbasi
force-pushed
the
sc-synch-fix
branch
from
80e5107 to
a85cf0c
Compare
Contributor
Author
|
thanks @rdblue, yeah this is a safe change so I excluded it. |
piyushnarang
pushed a commit
to piyushnarang/parquet-mr
that referenced
this pull request
Jun 15, 2016
Reads of the `finishCalled` variable are properly synchronized, but writes are not -- so there's some sort of inconsistent synch. going on here. This PR fixes that. /cc @rdblue can you please take a look? Author: Nezih Yigitbasi <nyigitbasi@netflix.com> Closes apache#334 from nezihyigitbasi/sc-synch-fix and squashes the following commits: a85cf0c [Nezih Yigitbasi] Synchronize writes to the finishCalled variable
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
Reads of the `finishCalled` variable are properly synchronized, but writes are not -- so there's some sort of inconsistent synch. going on here. This PR fixes that. /cc @rdblue can you please take a look? Author: Nezih Yigitbasi <nyigitbasi@netflix.com> Closes apache#334 from nezihyigitbasi/sc-synch-fix and squashes the following commits: a85cf0c [Nezih Yigitbasi] Synchronize writes to the finishCalled variable
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 10, 2017
Reads of the `finishCalled` variable are properly synchronized, but writes are not -- so there's some sort of inconsistent synch. going on here. This PR fixes that. /cc @rdblue can you please take a look? Author: Nezih Yigitbasi <nyigitbasi@netflix.com> Closes apache#334 from nezihyigitbasi/sc-synch-fix and squashes the following commits: a85cf0c [Nezih Yigitbasi] Synchronize writes to the finishCalled variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads of the
finishCalledvariable are properly synchronized, but writes are not -- so there's some sort of inconsistent synch. going on here. This PR fixes that./cc @rdblue can you please take a look?