PARQUET-569: Separate metadata filtering for ranges and offsets. #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Range filtering should use the row group midpoint and offset filtering should use the start offset.
Member
|
do we need to add tests for this? I presume the previous behavior was wrong? |
Contributor
Author
|
Yes, the previous behavior was wrong. I'll add a test. |
Contributor
Author
|
@julienledem, I added a test so this is good to go. We've also verified that it fixes the bug in Hive. |
Member
|
+1 |
piyushnarang
pushed a commit
to piyushnarang/parquet-mr
that referenced
this pull request
Jun 15, 2016
Range filtering should use the row group midpoint and offset filtering should use the start offset. Author: Ryan Blue <blue@apache.org> Closes apache#337 from rdblue/PARQUET-569-fix-metadata-filter and squashes the following commits: 6171af4 [Ryan Blue] PARQUET-569: Add tests for new offset metadata filter. 3fe2d5e [Ryan Blue] PARQUET-569: Separate metadata filtering for ranges and offsets.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
Range filtering should use the row group midpoint and offset filtering should use the start offset. Author: Ryan Blue <blue@apache.org> Closes apache#337 from rdblue/PARQUET-569-fix-metadata-filter and squashes the following commits: 6171af4 [Ryan Blue] PARQUET-569: Add tests for new offset metadata filter. 3fe2d5e [Ryan Blue] PARQUET-569: Separate metadata filtering for ranges and offsets.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 10, 2017
Range filtering should use the row group midpoint and offset filtering should use the start offset. Author: Ryan Blue <blue@apache.org> Closes apache#337 from rdblue/PARQUET-569-fix-metadata-filter and squashes the following commits: 6171af4 [Ryan Blue] PARQUET-569: Add tests for new offset metadata filter. 3fe2d5e [Ryan Blue] PARQUET-569: Separate metadata filtering for ranges and offsets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Range filtering should use the row group midpoint and offset filtering
should use the start offset.