PARQUET-544: Add closed flag to allow for closeable contract adherence #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mred-cmd
changed the title
Member
|
LGTM |
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
The closeable interface states: > Closes this stream and releases any system resources associated with it. If the stream is already closed then invoking this method has no effect. As InternalParquetRecordWriter implements this interface we should adhere to this contract. Author: Mark Reddy <mark.l.reddy@gmail.com> Closes apache#345 from markreddy/PARQUET-544-adhere-to-closeable-contract and squashes the following commits: 135db9b [Mark Reddy] PARQUET-544: add closed flag to allow for adherence to closeable contract
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 10, 2017
The closeable interface states: > Closes this stream and releases any system resources associated with it. If the stream is already closed then invoking this method has no effect. As InternalParquetRecordWriter implements this interface we should adhere to this contract. Author: Mark Reddy <mark.l.reddy@gmail.com> Closes apache#345 from markreddy/PARQUET-544-adhere-to-closeable-contract and squashes the following commits: 135db9b [Mark Reddy] PARQUET-544: add closed flag to allow for adherence to closeable contract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The closeable interface states:
As InternalParquetRecordWriter implements this interface we should adhere to this contract.