PARQUET-645: Fix null handling in DictionaryFilter. #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Member
|
LGTM |
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
This fixes how null is handled by `DictionaryFilter` for equals predicates. Null is never in the dictionary and is encoded by the definition level, so the `DictionaryFilter` would never find the value in the dictionary and would incorrectly filter row groups whenever the filter was `col == null`. Author: Ryan Blue <blue@apache.org> Closes apache#348 from rdblue/PARQUET-645-fix-null-dictionary-filter and squashes the following commits: ae8dd41 [Ryan Blue] PARQUET-645: Fix null handling in DictionaryFilter.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 10, 2017
This fixes how null is handled by `DictionaryFilter` for equals predicates. Null is never in the dictionary and is encoded by the definition level, so the `DictionaryFilter` would never find the value in the dictionary and would incorrectly filter row groups whenever the filter was `col == null`. Author: Ryan Blue <blue@apache.org> Closes apache#348 from rdblue/PARQUET-645-fix-null-dictionary-filter and squashes the following commits: ae8dd41 [Ryan Blue] PARQUET-645: Fix null handling in DictionaryFilter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes how null is handled by
DictionaryFilterfor equals predicates. Null is never in the dictionary and is encoded by the definition level, so theDictionaryFilterwould never find the value in the dictionary and would incorrectly filter row groups whenever the filter wascol == null.