PARQUET-389: Support predicate push down on missing columns. #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@danielcweeks, @liancheng, this is to avoid the predicate push-down problems in Spark. Can you review? Thanks! |
Contributor
|
+1 |
|
+1 as well. Thanks! |
Contributor
|
Is it possible to have a 1.8.2 release that includes this fix? I just checked and it seems that there isn't a dedicated branch for 1.8.x? |
Member
|
I am curious, why this patch doesn't do the same thing to the Is it intentional? |
Member
|
@liancheng @rdblue @danielcweeks I submitted #389 to extend this kind of fixing to |
asfgit
pushed a commit
that referenced
this pull request
Dec 8, 2016
This extends the fixing #354 to UserDefinedPredicate. Author: Liang-Chi Hsieh <viirya@gmail.com> Closes #389 from viirya/PARQUET-791 and squashes the following commits: d6be37d [Liang-Chi Hsieh] Address comment. 7e929c3 [Liang-Chi Hsieh] PARQUET-791: Add missing column support for UserDefinedPredicate.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
Predicate push-down will complain when predicates reference columns that aren't in a file's schema. This makes it difficult to implement predicate push-down in engines where schemas evolve because each task needs to process the predicates and prune references to columns not in that task's file. This PR implements predicate evaluation for missing columns, where the values are all null. This allows engines to pass predicates as they are written. A future commit should rewrite the predicates to avoid the extra work currently done in record-level filtering, but that isn't included here because it is an optimization. Author: Ryan Blue <blue@apache.org> Closes apache#354 from rdblue/PARQUET-389-predicate-push-down-on-missing-columns and squashes the following commits: b4d809a [Ryan Blue] PARQUET-389: Support record-level filtering with missing columns. 91b841c [Ryan Blue] PARQUET-389: Add missing column support to StatisticsFilter. 275f950 [Ryan Blue] PARQUET-389: Add missing column support to DictionaryFilter.
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
This extends the fixing apache#354 to UserDefinedPredicate. Author: Liang-Chi Hsieh <viirya@gmail.com> Closes apache#389 from viirya/PARQUET-791 and squashes the following commits: d6be37d [Liang-Chi Hsieh] Address comment. 7e929c3 [Liang-Chi Hsieh] PARQUET-791: Add missing column support for UserDefinedPredicate.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 10, 2017
Predicate push-down will complain when predicates reference columns that aren't in a file's schema. This makes it difficult to implement predicate push-down in engines where schemas evolve because each task needs to process the predicates and prune references to columns not in that task's file. This PR implements predicate evaluation for missing columns, where the values are all null. This allows engines to pass predicates as they are written. A future commit should rewrite the predicates to avoid the extra work currently done in record-level filtering, but that isn't included here because it is an optimization. Author: Ryan Blue <blue@apache.org> Closes apache#354 from rdblue/PARQUET-389-predicate-push-down-on-missing-columns and squashes the following commits: b4d809a [Ryan Blue] PARQUET-389: Support record-level filtering with missing columns. 91b841c [Ryan Blue] PARQUET-389: Add missing column support to StatisticsFilter. 275f950 [Ryan Blue] PARQUET-389: Add missing column support to DictionaryFilter.
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 10, 2017
This extends the fixing apache#354 to UserDefinedPredicate. Author: Liang-Chi Hsieh <viirya@gmail.com> Closes apache#389 from viirya/PARQUET-791 and squashes the following commits: d6be37d [Liang-Chi Hsieh] Address comment. 7e929c3 [Liang-Chi Hsieh] PARQUET-791: Add missing column support for UserDefinedPredicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Predicate push-down will complain when predicates reference columns that aren't in a file's schema. This makes it difficult to implement predicate push-down in engines where schemas evolve because each task needs to process the predicates and prune references to columns not in that task's file. This PR implements predicate evaluation for missing columns, where the values are all null. This allows engines to pass predicates as they are written.
A future commit should rewrite the predicates to avoid the extra work currently done in record-level filtering, but that isn't included here because it is an optimization.