Skip to content

PARQUET-1771: Support configurable for DirectByteBufferAllocator from Hadoop Configuration #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LiShuMing wants to merge 2 commits into from
Closed

PARQUET-1771: Support configurable for DirectByteBufferAllocator from Hadoop Configuration #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58463b1
PARQUET-1771: Support configurable for DirectByteBufferAllocator from…
LiShuMing Jan 16, 2020
c313034
Fix comments
LiShuMing Jan 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions parquet-hadoop/src/main/java/org/apache/parquet/HadoopReadOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

import java.util.Map;

import static org.apache.parquet.hadoop.ParquetInputFormat.ALLOCATOR_DIRECT_BYTEBUFFER_ENABLED;
import static org.apache.parquet.hadoop.ParquetInputFormat.COLUMN_INDEX_FILTERING_ENABLED;
import static org.apache.parquet.hadoop.ParquetInputFormat.DICTIONARY_FILTERING_ENABLED;
import static org.apache.parquet.hadoop.ParquetInputFormat.BLOOM_FILTERING_ENABLED;
Expand Down Expand Up @@ -91,6 +92,7 @@ public Builder(Configuration conf) {
useStatsFilter(conf.getBoolean(STATS_FILTERING_ENABLED, true));
useRecordFilter(conf.getBoolean(RECORD_FILTERING_ENABLED, true));
useColumnIndexFilter(conf.getBoolean(COLUMN_INDEX_FILTERING_ENABLED, true));
useDirectByteBufferAllocator(conf.getBoolean(ALLOCATOR_DIRECT_BYTEBUFFER_ENABLED, false));
usePageChecksumVerification(conf.getBoolean(PAGE_VERIFY_CHECKSUM_ENABLED,
usePageChecksumVerification));
useBloomFilter(conf.getBoolean(BLOOM_FILTERING_ENABLED, true));
Expand Down
8 changes: 8 additions & 0 deletions parquet-hadoop/src/main/java/org/apache/parquet/ParquetReadOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
package org.apache.parquet;

import org.apache.parquet.bytes.ByteBufferAllocator;
import org.apache.parquet.bytes.DirectByteBufferAllocator;
import org.apache.parquet.bytes.HeapByteBufferAllocator;
import org.apache.parquet.compression.CompressionCodecFactory;
import org.apache.parquet.filter2.compat.FilterCompat;
Expand Down Expand Up @@ -242,6 +243,13 @@ public Builder withRecordFilter(FilterCompat.Filter rowGroupFilter) {
return this;
}

public Builder useDirectByteBufferAllocator(boolean useDirectByteBuffer) {
if (useDirectByteBuffer) {
this.allocator = new DirectByteBufferAllocator();
}
return this;
}

public Builder withRange(long start, long end) {
this.metadataFilter = ParquetMetadataConverter.range(start, end);
return this;
Expand Down
5 changes: 5 additions & 0 deletions parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetInputFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,11 @@ public class ParquetInputFormat<T> extends FileInputFormat<Void, T> {
*/
public static final String BLOOM_FILTERING_ENABLED = "parquet.filter.bloom.enabled";

/**
* key to configure whether direct bytebuffer allocator is enabled
*/
public static final String ALLOCATOR_DIRECT_BYTEBUFFER_ENABLED = "parquet.allocator.direct.enabled";

/**
* key to turn on or off task side metadata loading (default true)
* if true then metadata is read on the task side and some tasks may finish immediately.
Expand Down