Skip to content

Conversation

@tomwhite
Copy link
Member

Update of the minimal fix discussed in https://github.com/apache/incubator-parquet-mr/pull/1, with the recursive call changed to to a loop.

@rdblue
Copy link
Contributor

rdblue commented Jun 26, 2014

+1 Looks good to me.

@julienledem
Copy link
Member

LGTM.
Could you Open a parquet JIRA and prefix the name of the PR with its ID as described in the following link ?
https://github.com/apache/incubator-parquet-mr/pull/8/files?short_path=6a33714#diff-6a3371457528722a734f3c51d9238c13

@rdblue
Copy link
Contributor

rdblue commented Jun 27, 2014

I opened PARQUET-9 for this.

@dvryaboy
Copy link
Contributor

My apache git credentials seem to be borked so I can't merge. You guys are both committers, feel free to merge it....

@julienledem
Copy link
Member

Could you prefix the name of this PR with "PARQUET-9:" ?
Thank you

@tomwhite tomwhite changed the title Filtering records across multiple blocks PARQUET-9: Filtering records across multiple blocks Jul 16, 2014
@asfgit asfgit closed this in 2d8ebdb Jul 16, 2014
rdblue pushed a commit to rdblue/parquet-mr that referenced this pull request Aug 11, 2014
Update of the minimal fix discussed in https://github.com/apache/incubator-parquet-mr/pull/1, with the recursive call changed to to a loop.

Author: Tom White <tom@cloudera.com>
Author: Steven Willis <swillis@compete.com>

Closes apache#9 from tomwhite/filtering-records-across-multiple-blocks and squashes the following commits:

afb08a4 [Tom White] Minimal fix
9e723ee [Steven Willis] Test for filtering records across multiple blocks
rdblue pushed a commit to rdblue/parquet-mr that referenced this pull request Feb 6, 2015
Update of the minimal fix discussed in https://github.com/apache/incubator-parquet-mr/pull/1, with the recursive call changed to to a loop.

Author: Tom White <tom@cloudera.com>
Author: Steven Willis <swillis@compete.com>

Closes apache#9 from tomwhite/filtering-records-across-multiple-blocks and squashes the following commits:

afb08a4 [Tom White] Minimal fix
9e723ee [Steven Willis] Test for filtering records across multiple blocks
chenjunjiedada pushed a commit to chenjunjiedada/parquet-mr that referenced this pull request Aug 3, 2019
Skip hidden columns when checking encoding
LantaoJin pushed a commit to LantaoJin/parquet-mr that referenced this pull request Jun 15, 2021
parthchandra pushed a commit to parthchandra/incubator-parquet-mr that referenced this pull request May 13, 2022
sunchao added a commit to sunchao/parquet-mr that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants