PARQUET-387: Improve NPE message when avro arrays contain null. #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the NPE had no error message but the Avro support accepts schemas that have nullable array elements.
Contributor
Author
|
@liancheng could you take a look at this? Thanks! |
Contributor
|
The change LGTM, would be nice to have a test for it though. |
Contributor
Author
|
Thanks @liancheng, I updated the test case for nulls to validate that the error message was set correctly. |
Contributor
Author
|
Looks like the test failure is from a flaky MemoryManager test, not a real issue. |
Contributor
|
+1. Let me try to merge this one :) |
Contributor
|
Unfortunately I failed to merge this PR with the following error :( Seems that my committership hasn't taken effect yet? (I've already followed instructions on this page: https://parquet.apache.org/contribute/) |
Contributor
Author
|
Thanks for trying, @liancheng. The permissions are controlled by config files on an Apache server, I'll look into it. |
piyushnarang
pushed a commit
to piyushnarang/parquet-mr
that referenced
this pull request
Jun 15, 2016
Previously, the NPE had no error message but the Avro support accepts schemas that have nullable array elements. Author: Ryan Blue <blue@apache.org> Closes apache#291 from rdblue/PARQUET-387-fix-npe-message and squashes the following commits: 39d3c83 [Ryan Blue] PARQUET-387: Update test case to verify help message. d6b6bd8 [Ryan Blue] PARQUET-387: Improve NPE message when avro arrays contain null.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jul 13, 2016
Previously, the NPE had no error message but the Avro support accepts schemas that have nullable array elements. Author: Ryan Blue <blue@apache.org> Closes apache#291 from rdblue/PARQUET-387-fix-npe-message and squashes the following commits: 39d3c83 [Ryan Blue] PARQUET-387: Update test case to verify help message. d6b6bd8 [Ryan Blue] PARQUET-387: Improve NPE message when avro arrays contain null.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
Previously, the NPE had no error message but the Avro support accepts schemas that have nullable array elements. Author: Ryan Blue <blue@apache.org> Closes apache#291 from rdblue/PARQUET-387-fix-npe-message and squashes the following commits: 39d3c83 [Ryan Blue] PARQUET-387: Update test case to verify help message. d6b6bd8 [Ryan Blue] PARQUET-387: Improve NPE message when avro arrays contain null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the NPE had no error message but the Avro support accepts
schemas that have nullable array elements.