-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file with nesting two-level list structure #60
base: master
Are you sure you want to change the base?
Conversation
I don't understand how the structure here is different from the "list of lists" example in https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#lists Witness:
vs.
|
My bad! I pasted the wrong result which disabled |
data/README.md
Outdated
@@ -53,6 +53,7 @@ | |||
| incorrect_map_schema.parquet | Contains a Map schema without explicitly required keys, produced by Presto. See [note](#incorrect-map-schema) | | |||
| column_chunk_key_value_metadata.parquet | two INT32 columns, one with column chunk key-value metadata {"foo": "bar", "thisiskeywithoutvalue": null} note that the second key "thisiskeywithoutvalue", does not have a value, but the value can be mapped to an empty string "" when read depending on the client | | |||
| sorting_columns.parquet | INT64 and BYTE_ARRAY columns with first column with nulls first and descending, second column with nulls last and ascending. This file contains two row groups with same data and sorting columns. | | |||
| old_list_structure.parquet | Single LIST<LIST<INT32>> column with legacy two-level list structure | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document the file like you did in the PR description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added. Please take a look again. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General LGTM
|
||
Here is the file metadata printed by parquet-cli: | ||
``` | ||
File path: /tmp/old_list_structure.parquet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should /tmp be here or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matches the file location in the code above. :)
Here is the file metadata printed by parquet-cli: | ||
``` | ||
File path: /tmp/old_list_structure.parquet | ||
Created by: parquet-mr version 1.14.3 (build b5e376a2caee767a11e75b783512b14cf8ca90ec) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this build a valid release? Or just run by master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a released version. Otherwise it will be 1.14.3-SNAPSHOT.
See: apache/arrow#43994
The Parquet file was created by parquet-java 1.14.3 with following code:
File metadata using parquet-cli:
Data using parquet-cli: