Skip to content

Update sbt-multi-jvm & sbt-assembly #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raboof merged 8 commits into from
Apr 29, 2024
Merged

Update sbt-multi-jvm & sbt-assembly #193

raboof merged 8 commits into from
Apr 29, 2024

Conversation

@Roiocam
Copy link
Member

@Roiocam Roiocam commented Apr 29, 2024 •
edited
Loading

Motivation

Resolves #192

I am trying to roll back #188, but this does not work. That's mean it not related on #188.

@Roiocam Roiocam marked this pull request as draft April 29, 2024 02:31
@Roiocam
Copy link
Member Author

Roiocam commented Apr 29, 2024 •
edited
Loading

ci start testing. ready for review

@Roiocam Roiocam marked this pull request as ready for review April 29, 2024 03:41
@Roiocam
Copy link
Member Author

Roiocam commented Apr 29, 2024

@raboof would you like to take a look?

@Roiocam Roiocam marked this pull request as draft April 29, 2024 05:54
@Roiocam Roiocam marked this pull request as ready for review April 29, 2024 06:35
raboof
raboof approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though it still seems we're relying on behavior of sbt that I'm not sure is documented/intended/reliable, which is somewhat scary, this seems to work so I'm in favor of this change.

@raboof raboof merged commit b7bd1ed into apache:main Apr 29, 2024
raboof added a commit to raboof/pekko-persistence-cassandra that referenced this pull request Jun 7, 2024
@raboof
add sbt-reproducible-builds
0cb79ae 
Another go at apache#71/apache#80, might work now that apache#193 was fixed
raboof added a commit to raboof/pekko-persistence-cassandra that referenced this pull request Jun 7, 2024
@raboof
add sbt-reproducible-builds
d45c8be 
Another go at apache#71/apache#80, might work now that apache#193 was fixed
@raboof raboof mentioned this pull request Jun 7, 2024
Closed
raboof added a commit that referenced this pull request Jun 8, 2024
@Roiocam @raboof
add sbt-reproducible-builds and fix lanucher builds (#206)
c69cfae 
* add sbt-reproducible-builds

Another go at #71/#80, might work now that #193 was fixed

* fix: cassandraLauncher build with ReproducibleBuildsPlugin

* chore: use unmanagedResources

* chore: remove target depend

---------

Co-authored-by: Arnout Engelen <arnout@bzzt.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raboof raboof raboof approved these changes

@He-Pin He-Pin He-Pin approved these changes

@mdedetrich mdedetrich Awaiting requested review from mdedetrich

@pjfanning pjfanning Awaiting requested review from pjfanning

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rethink cassandra-launcher approach

3 participants

@Roiocam @raboof @He-Pin