Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projection implementation for MySQL support #177

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ptrdom
Copy link
Contributor

@ptrdom ptrdom commented Nov 18, 2024

Related to #158.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are breaking backwards compatibility here, can we convert from case class to class too? Similar to how R2dbcSettings is implemented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course this class is different from R2dbcSettings in a way that users can manually construct it - it is not constructed by config only, so will have to keep the means to set/modify its attributes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjfanning Do you have a preferred solution for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the TODO on the class - so I don't mind a rewrite for 1.1.0.

It would still be nice to minimise source incompatible changes - i.e. code with against 1.0.0 would ideally still be compilable with 1.1.0.

@pjfanning
Copy link
Contributor

I committed a fix for the merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants