Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run osgiBundle when it's not required. #1032

Open
Tracked by #1052
He-Pin opened this issue Jan 23, 2024 · 5 comments
Open
Tracked by #1052

Don't run osgiBundle when it's not required. #1032

He-Pin opened this issue Jan 23, 2024 · 5 comments
Labels
build sbt or build of the project

Comments

@He-Pin
Copy link
Member

He-Pin commented Jan 23, 2024

Motivation:
osgibundle is so slow, I prefer to not run it if it's not needed.
image
@He-Pin He-Pin added the build sbt or build of the project label Jan 23, 2024
@He-Pin He-Pin changed the title Don't run osgiBundle when it's not requred. Don't run osgiBundle when it's not required. Jan 23, 2024
@Roiocam
Copy link
Member

Roiocam commented Jan 24, 2024

Don't know why, but this only spent 2s on my laptop(M1 macOs).

@mdedetrich
Copy link
Contributor

Don't know why, but this only spent 2s on my laptop(M1 macOs).

I don't even notice it, and caching was recently added

@He-Pin
Copy link
Member Author

He-Pin commented Jan 24, 2024

@mdedetrich @Roiocam Trigger an JMH bench you will notice it.
image
And my PC is using SSD too.

@Roiocam
Copy link
Member

Roiocam commented Jan 24, 2024

Trigger an JMH bench you will notice it.

Run JMH after clean up, it only costs 3s when executing stream osgiBundle

@He-Pin
Copy link
Member Author

He-Pin commented Jan 24, 2024

Jmh/run -i 10 -wi 10 -f1 -t1 .*CollectBenchmark.*
Have no idea :(
image

@Roiocam Roiocam mentioned this issue Jan 26, 2024
Open
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build sbt or build of the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@He-Pin @mdedetrich @Roiocam