Implement a cache based on hashing of the inputs of bundleTask #100
Conversation
…and has been produced using identical inputs
|
Please do not merge yet. I am going to implement alternative cache strategy based on hash or on lastModified... |
@romainreuillon Is this PR being worked on? |
|
Hi @mdedetrich, it is actually complete. There are 2 caching modes: modification time based or hash based. I'll implement an hybrid mode, checking modification time and then hash at some point but it requires way more work. I'll do that in a new PR. This one is ready to merge. |
|
@romainreuillon Released as |
| import _root_.java.nio.file._ | ||
| import _root_.scala.collection.JavaConverters._ | ||
| val path = tmpArtifactDirectoryPath.toPath | ||
| Files.walk(path).iterator.asScala.map(f => f.toFile -> path.relativize(f).toString).filterNot { case (_, p) => p == "META-INF/MANIFEST.MF" }.toTraversable |
There was a problem hiding this comment.
@mdedetrich This "META-INF/MANIFEST.MF" maybe cause an issue on Windows.
could you change to this like #115 does?
Files.walk(path).iterator.asScala.map(f => f.toFile -> path.relativize(f))
.collect { case (f, p) if p != (file("META-INF") / "MANIFEST.MF").toPath => (f, p.toString) }There was a problem hiding this comment.
NVM, I walked into the wrong CR path, this is an outdated comment.
In case no file and no settings have been modified and the bundle exist do no generate it.
Add an opt-in key to avoid breaking things...
It solves #27