Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot: guava #1553

Open
raboof opened this issue Nov 7, 2024 · 0 comments
Open

dependabot: guava #1553

raboof opened this issue Nov 7, 2024 · 0 comments

Comments

@raboof
Copy link
Member

raboof commented Nov 7, 2024

our GitHub 'security' tab claims that we depend on a version of guava that is vulnerable to GHSA-mvr2-9pj6-7w5j .

I think this is a false positive: I think this is the guava that comes in as a transitive dependency of leveldb, but this is an optional;provided dependency. This apparently ends up in the compile-internal and optional scopes.

I think we should probably exclude the compile-internal and optional scopes, and use the dependabot security report for artifacts that actually come in as transitive dependencies for our users. The chance that an advisory for an optional/provided/test/built-time dependency actually impacts our build seems to small to justify the noise it adds.

raboof added a commit to raboof/pekko that referenced this issue Nov 7, 2024
This makes it easier to use the dependabot security report for artifacts
that actually come in as transitive dependencies for our users. The
chance that an advisory for an optional/provided/test/built-time
dependency actually impacts our build seems to small to justify the
noise it adds.

Fixes apache#1553
raboof added a commit to raboof/pekko that referenced this issue Nov 7, 2024
This makes it easier to use the dependabot security report for artifacts
that actually come in as transitive dependencies for our users. The
chance that an advisory for an optional/provided/test/built-time
dependency actually impacts our build seems to small to justify the
noise it adds.

Fixes apache#1553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant