feat: Add Pattern timeout support #1424
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My wife just come to hangzhou, and I may don't have enough time to polish this , any feed back is welcome, I will try to get it done soon. |
|
Can this wait till 1.1.1 release? |
Roiocam
reviewed
Aug 23, 2024
| val p = Promise[T]() | ||
| val timeout = using.scheduleOnce(duration) { | ||
| p.tryFailure(new TimeoutException(s"Timeout of $duration expired")) | ||
| if (future.isInstanceOf[CompletableFuture[T]]) { |
There was a problem hiding this comment.
cool feature, but seem like it doesn't support scala future, because it haven't cancel/interrrupt method
|
what is the plan for the shipping of this PR? it looks like it can be help to implement Hedged requests. |
|
@Roiocam Chinese Spring Festival is coming, I would like to have this done before that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
refs: #1359
still wip, test is missing