Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit dependabot dependency graph to Github #366

Merged

Conversation

mdedetrich
Copy link
Contributor

This PR uses scala centers official integration of sbt with github's dependabot (see https://github.com/scalacenter/sbt-dependency-submission) to submit any potential security vulnerabilities. This is a more practical solution compared to #289 especially in regards to getting it ready for release candidate.

https://github.com/aiven/guardian-for-apache-kafka/security/dependabot is a nice demonstration of what it looks like when it finds security vulnerabilities.

Copy link
Contributor

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich
Copy link
Contributor Author

@pjfanning The PR has been approved but I will wait for your approval incase you have any comments

@raboof
Copy link
Member

raboof commented Jun 2, 2023

https://github.com/aiven/guardian-for-apache-kafka/security/dependabot is a nice demonstration of what it looks like when it finds security vulnerabilities.

(this page is only visible if you have permissions for that repo)

@mdedetrich
Copy link
Contributor Author

(this page is only visible if you have permissions for that repo)

Ah thanks. Let me see if INFRA is able to help out here.

@mdedetrich mdedetrich force-pushed the submit-dependabot-dependency-graph branch from fa38835 to 713604d Compare June 2, 2023 08:36
@mdedetrich
Copy link
Contributor Author

https://github.com/aiven/guardian-for-apache-kafka/security/dependabot is a nice demonstration of what it looks like when it finds security vulnerabilities.

(this page is only visible if you have permissions for that repo)

Thanks, it seems like .asf.yml already supports this so I enabled it right now, force pushed.

@mdedetrich mdedetrich force-pushed the submit-dependabot-dependency-graph branch from 713604d to 632a2f5 Compare June 3, 2023 07:52
@mdedetrich
Copy link
Contributor Author

I am going to merge the PR fow now so we can see if there are any potential issues before release, can always revert if there is a problem./

@mdedetrich mdedetrich merged commit 9aa4e1d into apache:main Jun 3, 2023
@mdedetrich mdedetrich deleted the submit-dependabot-dependency-graph branch June 3, 2023 08:04
@pjfanning
Copy link
Contributor

pjfanning commented Jun 7, 2023

We have 100% false negatives in https://github.com/apache/incubator-pekko/security/dependabot. Not one of the jackson-databind is applicable. It appears that whatever is going, dependabot is not aware that we are using jackson 2.14.3. All the issues that dependabot highlights are fixed in that version.

Some alerts relate to org.codehaus.jackson:jackson-mapper-asl but sbt dependencyTree does not show any such dependency.

@mdedetrich
Copy link
Contributor Author

We have 100% false negatives in https://github.com/apache/incubator-pekko/security/dependabot. Not one of the jackson-databind is applicable. It appears that whatever is going, dependabot is not aware that we are using jackson 2.14.3. All the issues that dependabot highlights are fixed in that version.

Some alerts relate to org.codehaus.jackson:jackson-mapper-asl but sbt dependencyTree does not show any such dependency.

Looking into this now, seems to only be happening with Pekko. Under the hood the workflow is an sbt plugin that resolves the dependency graph so it must be doing something odd.

@mdedetrich
Copy link
Contributor Author

Issue made at #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants