PHOENIX-7507 Update ROW_KEY_MATCHER column type to be VARBINARY_ENCODED #2060
Conversation
| case Types.VARBINARY: | ||
| pkTypeStr = "VARBINARY"; | ||
| break; | ||
| case 9000: |
There was a problem hiding this comment.
nit: PDataType.VARBINARY_ENCODED_TYPE
| @@ -183,6 +194,15 @@ private Object getData(PDataType type) { | |||
| case Types.TIMESTAMP: | |||
| //pkTypeStr = "TIMESTAMP"; | |||
| return new Timestamp(System.currentTimeMillis() + rnd.nextInt(50000)); | |||
| case Types.VARBINARY: | |||
| // pkTypeStr = "VARBINARY"; | |||
| case 9000: | |||
There was a problem hiding this comment.
same here: PDataType.VARBINARY_ENCODED_TYPE
| RandomStringUtils.randomAlphanumeric(25).getBytes(), | ||
| Bytes.toBytes(rnd.nextInt(50000)), | ||
| Bytes.toBytes(Math.floor(rnd.nextInt(50000) * rnd.nextDouble()))); | ||
| LOGGER.info("***************************************************************************"); |
| pkType3Str, pkOrders[0].name(), pkOrders[1].name(), pkOrders[2].name(), | ||
| baseTableName, partitionName)); | ||
| baseTableName, partitionName); | ||
| LOGGER.info(String.format("Created global view %s", globalViewSQL)); |
There was a problem hiding this comment.
nit: LOGGER.info("Created global view {}", globalViewSQL)
| String.format(GLOBAL_INDEX_TEMPLATE, indexNamePrefix, globalViewName)); | ||
| String globalViewIndexSQL = | ||
| String.format(GLOBAL_INDEX_TEMPLATE, indexNamePrefix, globalViewName); | ||
| LOGGER.info(String.format("Created global view index %s", globalViewIndexSQL)); |
There was a problem hiding this comment.
same here, String.format not needed
| String.format(VIEW_WITH_PK_TEMPLATE, tenantViewName, globalViewName, | ||
| getWhereClause(pkNames, pkTypes), tenantViewOptions)); | ||
| getWhereClause(pkNames, pkTypes), tenantViewOptions); | ||
| LOGGER.info(String.format("Created tenant view (WITH_PK) %s", viewWithPKSQL)); |
There was a problem hiding this comment.
nit: LOGGER.info("Created tenant view (WITH_PK) {}", viewWithPKSQL)
| tenantViewOptions)); | ||
| String viewWithoutPKSQL = String.format(VIEW_WO_PK_TEMPLATE, tenantViewName, globalViewName, | ||
| tenantViewOptions); | ||
| LOGGER.info(String.format("Created tenant view ((WO_PK)) %s", viewWithoutPKSQL)); |
| )); | ||
|
|
||
| // View TTL is set to 10s => 10000 ms | ||
| //globalViewOptions.setTableProps(String.format("TTL=%d", viewTTL)); |
| tenantViewOptions.setTableProps(String.format("TTL=%d", viewTTL)); | ||
|
|
||
| // OtherOptions otherOptions = new OtherOptions(); | ||
| // otherOptions.setTableCFs(asList(null, null, null)); |
| int viewTTL = VIEW_TTL_10_SECS; | ||
| // Define the test schema. | ||
| // 1. Table with columns => (ORG_ID, KP, COL1, COL2, COL3), PK => (ORG_ID, KP) | ||
| // 2. GlobalView with columns => (ID, COL4, COL5, COL6), PK => (ID) |
There was a problem hiding this comment.
Update comments with actual column names
There was a problem hiding this comment.
+1, pending build results from https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2060/2/
The backward compatibility test failures are due to VARBINARY_ENCODED type not being in other branches (for e.g 5.1.*) @virajjasani |
No description provided.