overflow should not create size based on current value

apache · May 23, 2024 · 0779406 · 0779406
1 parent 0dec8a9
commit 0779406
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/...main/java/org/apache/pinot/segment/local/io/writer/impl/MutableOffHeapByteArrayStore.java b/...main/java/org/apache/pinot/segment/local/io/writer/impl/MutableOffHeapByteArrayStore.java
@@ -178,7 +178,9 @@ public MutableOffHeapByteArrayStore(PinotDataBufferMemoryManager memoryManager,
       int numArrays, int avgArrayLen) {
     _memoryManager = memoryManager;
     _allocationContext = allocationContext;
-    _startSize = numArrays * (avgArrayLen + 4); // For each array, we store the array and its startoffset (4 bytes)
+    int estimatedSize =
+        numArrays * (avgArrayLen + 4); // For each array, we store the array and its startoffset (4 bytes)
+    _startSize = estimatedSize > 0 ? estimatedSize : Integer.MAX_VALUE;
     expand(_startSize);
   }
 

diff --git a/.../java/org/apache/pinot/segment/local/io/writer/impl/MutableOffHeapByteArrayStoreTest.java b/.../java/org/apache/pinot/segment/local/io/writer/impl/MutableOffHeapByteArrayStoreTest.java
@@ -56,6 +56,14 @@ public void maxValueTest()
     store.close();
   }
 
+  @Test
+  public void startSizeOverflowTest()
+      throws Exception {
+    MutableOffHeapByteArrayStore store =
+        new MutableOffHeapByteArrayStore(_memoryManager, "stringColumn", 3, 1024 * 1024 * 1024);
+    store.close();
+  }
+
   @Test
   public void overflowTest()
       throws Exception {