Fix issue with group by combine operator when limit is zero (#13555)

apache · Jul 8, 2024 · 42b63d8 · 42b63d8
1 parent cf1a0f6
commit 42b63d8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/data/table/IndexedTable.java b/pinot-core/src/main/java/org/apache/pinot/core/data/table/IndexedTable.java
@@ -71,9 +71,9 @@ protected IndexedTable(DataSchema dataSchema, boolean hasFinalInput, QueryContex
       int trimSize, int trimThreshold, Map<Key, Record> lookupMap) {
     super(dataSchema);
 
-    Preconditions.checkArgument(resultSize > 0, "Result size should be a non-zero positive integer");
-    Preconditions.checkArgument(trimSize > 0, "Trim size should be a non-zero positive integer");
-    Preconditions.checkArgument(trimThreshold > 0, "Trim threshold should be a non-zero positive integer");
+    Preconditions.checkArgument(resultSize >= 0, "Result size can't be negative");
+    Preconditions.checkArgument(trimSize >= 0, "Trim size can't be negative");
+    Preconditions.checkArgument(trimThreshold >= 0, "Trim threshold can't be negative");
 
     _lookupMap = lookupMap;
     _hasFinalInput = hasFinalInput;

diff --git a/...tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java b/...tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
@@ -3472,6 +3472,13 @@ public void testBooleanAggregation()
     testQuery("SELECT BOOL_OR(CAST(Diverted AS BOOLEAN)) FROM mytable");
   }
 
+  @Test(dataProvider = "useBothQueryEngines")
+  public void testGroupByAggregationWithLimitZero(boolean useMultiStageQueryEngine)
+      throws Exception {
+    setUseMultiStageQueryEngine(useMultiStageQueryEngine);
+    testQuery("SELECT Origin, SUM(ArrDelay) FROM mytable GROUP BY Origin LIMIT 0");
+  }
+
   private String buildSkipIndexesOption(String columnsAndIndexes) {
     return "SET " + SKIP_INDEXES + "='" + columnsAndIndexes + "'; ";
   }