Fixing requestId generator bug in PinotBrokerDebug Resource

apache · Jul 30, 2024 · a137615 · a137615
1 parent a6cf197
commit a137615
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java b/pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java
@@ -84,7 +84,7 @@
 public class PinotBrokerDebug {
 
   // Request ID is passed to the RoutingManager to rotate the selected replica-group.
-  private final AtomicLong _requestIdGenerator = new AtomicLong();
+  private final static AtomicLong REQUEST_ID_GENERATOR = new AtomicLong();
 
   @Inject
   private BrokerRoutingManager _routingManager;
@@ -272,7 +272,10 @@ public String getServerRoutingStats() {
   }
 
   private long getRequestId() {
-    return _requestIdGenerator.getAndIncrement();
+    if (REQUEST_ID_GENERATOR.get() == Long.MAX_VALUE) {
+      REQUEST_ID_GENERATOR.set(0);
+    }
+    return REQUEST_ID_GENERATOR.getAndIncrement();
   }
 
   @GET