Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multistage]Support Timestamp Index in multi-stage engine #11409

Closed
wants to merge 1 commit into from

Conversation

xiangfu0
Copy link
Contributor

Best effort rewrite DateTrunc to use timestamp index hidden column if exists.

@xiangfu0 xiangfu0 changed the title Support Timestamp Index in multi-stage engine [multistage]Support Timestamp Index in multi-stage engine Aug 22, 2023
@xiangfu0 xiangfu0 added the multi-stage Related to the multi-stage query engine label Aug 22, 2023
@xiangfu0 xiangfu0 force-pushed the date-trunc-in-v2 branch 2 times, most recently from 94c5fc9 to e6c7476 Compare August 23, 2023 00:28
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #11409 (543eef6) into master (e0d0aeb) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11409      +/-   ##
============================================
+ Coverage     62.89%   62.93%   +0.03%     
- Complexity     1091     1093       +2     
============================================
  Files          2301     2301              
  Lines        123766   123766              
  Branches      18833    18833              
============================================
+ Hits          77845    77891      +46     
+ Misses        40376    40337      -39     
+ Partials       5545     5538       -7     
Flag Coverage Δ
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 62.90% <ø> (+0.03%) ⬆️
java-17 62.76% <ø> (+48.25%) ⬆️
java-20 62.79% <ø> (+0.02%) ⬆️
temurin 62.93% <ø> (+0.03%) ⬆️
unittests 62.92% <ø> (+0.03%) ⬆️
unittests1 67.45% <ø> (+0.04%) ⬆️
unittests2 14.51% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...e/pinot/common/function/TransformFunctionType.java 88.38% <ø> (ø)

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 xiangfu0 closed this Oct 14, 2023
@xiangfu0 xiangfu0 deleted the date-trunc-in-v2 branch October 14, 2023 10:25
@gortiz gortiz mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants