Adding record reader config/context param to record transformer #12520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaminathanmanish
force-pushed
the
recordTRansformer
branch
from
0242262 to
e82c597
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12520 +/- ##
============================================
- Coverage 61.75% 61.70% -0.05%
Complexity 207 207
============================================
Files 2436 2450 +14
Lines 133233 133552 +319
Branches 20636 20692 +56
============================================
+ Hits 82274 82406 +132
- Misses 44911 45055 +144
- Partials 6048 6091 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
swaminathanmanish
changed the title
klsince
reviewed
Feb 29, 2024
...-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/RecordTransformer.java
Outdated
Show resolved
Hide resolved
klsince
reviewed
Feb 29, 2024
...-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/RecordTransformer.java
Outdated
Show resolved
Hide resolved
klsince
approved these changes
Feb 29, 2024
swaminathanmanish
force-pushed
the
recordTRansformer
branch
from
b291dc9 to
f756923
Compare
klsince
added a commit
to klsince/pinot
that referenced
this pull request
Feb 29, 2024
…mer (apache#12520)" This reverts commit f0fcbd8.
Jackie-Jiang
pushed a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats in the PR:
Adding Record reader config/context to transform api, for transformer to use it during transformation of record.
Why its needed:
Custom transformers need to be perform transformations based on record reader configs (eg: file path). This change is to enable such transformations.