Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): update node version to 16 #12924

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

jayeshchoudhary
Copy link
Contributor

fixes #12756

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.17%. Comparing base (59551e4) to head (b58129d).
Report is 298 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12924      +/-   ##
============================================
+ Coverage     61.75%   62.17%   +0.42%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2502      +66     
  Lines        133233   136390    +3157     
  Branches      20636    21106     +470     
============================================
+ Hits          82274    84803    +2529     
- Misses        44911    45302     +391     
- Partials       6048     6285     +237     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 35.16% <ø> (-26.55%) ⬇️
java-21 62.05% <ø> (+0.43%) ⬆️
skip-bytebuffers-false 62.14% <ø> (+0.39%) ⬆️
skip-bytebuffers-true 62.04% <ø> (+34.31%) ⬆️
temurin 62.17% <ø> (+0.42%) ⬆️
unittests 62.17% <ø> (+0.42%) ⬆️
unittests1 46.75% <ø> (-0.14%) ⬇️
unittests2 27.93% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang added dependencies Pull requests that update a dependency file ui UI related issue labels Apr 15, 2024
@Jackie-Jiang Jackie-Jiang merged commit 4040a19 into apache:master Apr 15, 2024
20 of 21 checks passed
@tibrewalpratik17
Copy link
Contributor

@jayeshchoudhary does this patch change the way npm fetches and auth checks during builds.
After this change, I am getting this error while building from local:

npm http fetch POST 403 https://unpm.uberinternal.com/-/npm/v1/security/advisories/bulk 1705ms

Reverting this change locally allows me to build successfully again.

We usually remove our token during builds using:

USSO_TOKEN=$(usso -ussh unpm.uberinternal.com -print 2> /dev/null)
    TOKEN=$(echo -n "ignored:$USSO_TOKEN" | base64)
    echo "//unpm.uberinternal.com/:_auth=$TOKEN" >> ~/.npmrc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ui UI related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update node version in install-node-and-npm build goal
4 participants