Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of collaborators to asf.yaml #13346

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

yashmayya
Copy link
Collaborator

  • ASF Infra allows Apache projects to assign the GitHub "triage" role (see permissions for each role here) to up to 10 "collaborators" (non-committers) per repository.
  • This allows for things like assigning, editing, and closing issues / PRs (without giving write-access to the code) and also adding / removing labels, requesting PR reviewers etc.
  • This has been adopted by various other Apache projects and is pretty useful as it allows non-committers to contribute additionally towards project maintenance activities.
  • In the Apache Kafka project, a policy was adopted to add the top 10 non-committer contributors from the past year (as per git shortlog) as collaborators and has been fairly successful. This PR is a proposal to adopt the same policy for the Apache Pinot project.
  • The collaborator list will be updated periodically to account for changes in contribution levels as well as collaborators potentially becoming committers.
> git shortlog --numbered --summary --since="1 year ago"

   256  dependabot[bot]
   206  Xiaotian (Jackie) Jiang
   154  Xiang Fu
    65  Rong Rong
    59  Gonzalo Ortiz Jaureguizar
    58  sullis
    49  Shen Yu
    46  Pratik Tibrewal
    44  Abhishek Sharma
    40  Saurabh Dubey
    35  Xiaobing
    30  Haitao Zhang
    30  Shounak kulkarni
    24  Christopher Peck
    20  soumitra-st
    19  Kartik Khare
    19  swaminathanmanish
    18  Yash Mayya
    17  Jayesh Choudhary
    16  Seunghyun Lee
    16  Vivek Iyer Vaidyanathan
    14  Johan Adami
    11  Prashant Pandey
    10  Tim Veil
     9  Aishik
     9  Ankit Sultana
     9  David Cromberge
     9  Ragesh Rajagopalan
     9  Xuanyi Li

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.08%. Comparing base (59551e4) to head (4a82baf).
Report is 586 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13346      +/-   ##
============================================
+ Coverage     61.75%   62.08%   +0.33%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2545     +109     
  Lines        133233   139819    +6586     
  Branches      20636    21695    +1059     
============================================
+ Hits          82274    86807    +4533     
- Misses        44911    46435    +1524     
- Partials       6048     6577     +529     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 62.04% <ø> (+0.33%) ⬆️
java-21 61.97% <ø> (+0.34%) ⬆️
skip-bytebuffers-false 62.07% <ø> (+0.32%) ⬆️
skip-bytebuffers-true 61.94% <ø> (+34.21%) ⬆️
temurin 62.08% <ø> (+0.33%) ⬆️
unittests 62.08% <ø> (+0.33%) ⬆️
unittests1 46.65% <ø> (-0.24%) ⬇️
unittests2 27.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit ad5ca34 into apache:master Jun 11, 2024
20 checks passed
@yashmayya
Copy link
Collaborator Author

Thanks Jackie! Mentioning the newly added collaborators here as an FYI - @sullis, @shenyu0127, @tibrewalpratik17, @abhioncbr, @zhtaoxiang, @shounakmk219, @itschrispeck, @soumitra-st, @swaminathanmanish, @yashmayya.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants