Fix flaky gauge value issue #13679
Merged
Fix flaky gauge value issue #13679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tibrewalpratik17 for identifying the issue, really appreciate it! Could you help add a unit test in |
tibrewalpratik17
force-pushed
the
fix_metric_missing_issue
branch
from
86db21c to
046a813
Compare
jackjlli
approved these changes
Jul 22, 2024
pinot-common/src/test/java/org/apache/pinot/common/metrics/AbstractMetricsTest.java
Show resolved
Hide resolved
tibrewalpratik17
force-pushed
the
fix_metric_missing_issue
branch
from
046a813 to
b6f6db0
Compare
tibrewalpratik17
force-pushed
the
fix_metric_missing_issue
branch
from
b6f6db0 to
a8fd649
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13679 +/- ##
============================================
+ Coverage 61.75% 61.97% +0.21%
+ Complexity 207 198 -9
============================================
Files 2436 2554 +118
Lines 133233 140567 +7334
Branches 20636 21868 +1232
============================================
+ Hits 82274 87111 +4837
- Misses 44911 46820 +1909
- Partials 6048 6636 +588
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ankitsultana
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #13629
Currently, we maintain a map
_gaugeValuesin theAbstractMetricsclass for gauge values. When adding a new gauge, we lock the entire operation of adding the gauge to the_gaugeValuesmap and themetricsRegistryfactory simultaneously (Ref). However, there was a bug where the removal was not done under a lock. This led to a race condition whenremoveGaugeandsetValueOfGaugewere called almost simultaneously. This could result in a scenario where the gauge is removed from the_gaugeValuesmap, thensetValueOfGaugetakes a lock on the map, adds it back to_gaugeValues, and registers it with_metricsRegistry, but thenremoveFromMetricsRegistryfrom theremoveGaugemethod kicks in, removing it from_metricsRegistry.This was specifically caught in our scenario by the way we have implemented our
_metricsRegistry. We have a thread where we loop through all the gauges every 10 seconds and emit the value. In our scenario,_metricsRegistrywas missing the gauge altogether because of the above race condition.