Merge RecordEnricher into RecordTransformer #13704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadilkhalifa
force-pushed
the
merge-enricher-transformer
branch
2 times, most recently
from
ce7e9d0 to
bffd235
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13704 +/- ##
============================================
+ Coverage 61.75% 62.02% +0.26%
+ Complexity 207 198 -9
============================================
Files 2436 2553 +117
Lines 133233 140605 +7372
Branches 20636 21874 +1238
============================================
+ Hits 82274 87205 +4931
- Misses 44911 46773 +1862
- Partials 6048 6627 +579
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aadilkhalifa
force-pushed
the
merge-enricher-transformer
branch
2 times, most recently
from
007c783 to
2aca00f
Compare
aadilkhalifa
force-pushed
the
merge-enricher-transformer
branch
from
2aca00f to
ccd307b
Compare
aadilkhalifa
changed the title
| */ | ||
| void enrich(GenericRow record); | ||
| } | ||
| //public interface RecordEnricher { |
There was a problem hiding this comment.
Please cleanup the commented lines, and files that are no longer needed. Same for other places
| @@ -129,7 +129,7 @@ public void build(@Nullable SegmentVersion segmentVersion, ServerMetrics serverM | |||
| recordReader.init(_realtimeSegmentImpl, sortedDocIds); | |||
| RealtimeSegmentSegmentCreationDataSource dataSource = | |||
| new RealtimeSegmentSegmentCreationDataSource(_realtimeSegmentImpl, recordReader); | |||
| driver.init(genConfig, dataSource, RecordEnricherPipeline.getPassThroughPipeline(), | |||
| driver.init(genConfig, dataSource, RecordTransformerPipeline.getPassThroughPipeline(), | |||
There was a problem hiding this comment.
We want to integrate the current RecordEnricher as one type of RecordTransformer. With that, we shouldn't need a separate pipeline other than TransformPipeline
|
Hey @aadilkhalifa, wanted to check if you would be taking these changes to completion? |
|
Merge #14601 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #13049