Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Use ByteString.EMPTY to Prevent Protobuf Version Pin to >3.19 #13720

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

ankitsultana
Copy link
Contributor

ByteString.empty() was added in 3.20.0. ByteString.EMPTY should be equivalent and will allow lower protobuf versions to be used.

@ankitsultana ankitsultana changed the title [minor] Use ByteString.EMPTY to Prevent Protobuf Version Pining to >3.19 [minor] Use ByteString.EMPTY to Prevent Protobuf Version Pin to >3.19 Jul 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.98%. Comparing base (59551e4) to head (d21c27c).
Report is 813 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13720      +/-   ##
============================================
+ Coverage     61.75%   61.98%   +0.22%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2554     +118     
  Lines        133233   140661    +7428     
  Branches      20636    21880    +1244     
============================================
+ Hits          82274    87182    +4908     
- Misses        44911    46847    +1936     
- Partials       6048     6632     +584     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 61.94% <ø> (+0.24%) ⬆️
java-21 61.86% <ø> (+0.24%) ⬆️
skip-bytebuffers-false 61.97% <ø> (+0.22%) ⬆️
skip-bytebuffers-true 61.83% <ø> (+34.11%) ⬆️
temurin 61.98% <ø> (+0.22%) ⬆️
unittests 61.97% <ø> (+0.22%) ⬆️
unittests1 46.42% <ø> (-0.47%) ⬇️
unittests2 27.77% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenboat chenboat merged commit f6da799 into apache:master Jul 31, 2024
20 checks passed
@ankitsultana ankitsultana deleted the fix-protobuf-bw branch July 31, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants