[timeseries] Fix Time Series Query Correctness Issue #14251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the time series engine in our cluster we found an undercount issue. This is likely because the AggregationOperator was not pulling all the docs matched by the filter.
This PR fixes that by calling
nextBlock
in a loop.Test Plan: Updated the existing UT so that it was able to detect this bug. To do this, the following was done:
sum(orderAmount)
over the entire data, with a single time bucket. The corresponding result was verified with CH.CH Query for loading and testing the new sample data: