Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust RequestUtils#getTableNames to get table names from both left and right sides of join #14554

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

AlexanderKM
Copy link
Contributor

@AlexanderKM AlexanderKM commented Nov 27, 2024

Currently when using a join query, the RequestUtils#getTableNames method will only return the table name from the left side of the query. So in this example, even when we join table1 and table2, the output of table names is only <table1>.

SELECT 
  table1.foo,
  table2.bar 
FROM 
  table1 
JOIN table2 ON table1.id = table2.id 
LIMIT 10;

This PR fixes this to output both the correct table names <table1, table2>

#14555

@AlexanderKM AlexanderKM marked this pull request as ready for review November 27, 2024 20:30
@Jackie-Jiang Jackie-Jiang added bugfix multi-stage Related to the multi-stage query engine labels Nov 27, 2024
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Jackie-Jiang Jackie-Jiang removed the multi-stage Related to the multi-stage query engine label Nov 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.94%. Comparing base (59551e4) to head (e95b6e0).
Report is 1398 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14554      +/-   ##
============================================
+ Coverage     61.75%   63.94%   +2.18%     
- Complexity      207     1570    +1363     
============================================
  Files          2436     2681     +245     
  Lines        133233   147067   +13834     
  Branches      20636    22568    +1932     
============================================
+ Hits          82274    94035   +11761     
- Misses        44911    46102    +1191     
- Partials       6048     6930     +882     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.88% <100.00%> (+2.17%) ⬆️
java-21 63.83% <100.00%> (+2.20%) ⬆️
skip-bytebuffers-false 63.93% <100.00%> (+2.18%) ⬆️
skip-bytebuffers-true 63.79% <100.00%> (+36.06%) ⬆️
temurin 63.94% <100.00%> (+2.18%) ⬆️
unittests 63.93% <100.00%> (+2.18%) ⬆️
unittests1 55.66% <100.00%> (+8.77%) ⬆️
unittests2 34.54% <0.00%> (+6.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashmayya yashmayya merged commit 2d470e7 into apache:master Nov 28, 2024
21 checks passed
@AlexanderKM AlexanderKM deleted the request-utils-tables-fix branch November 28, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants