Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky-test] Fix ForwardIndexHandlerTest.testAddOtherIndexForForwardIndexDisabledColumn() #14580

Merged

Conversation

Jackie-Jiang
Copy link
Contributor

The test will fail when max MV entries is 1 (random between 1 - 500). Revise the testing logic

Error:  org.apache.pinot.segment.local.segment.index.loader.ForwardIndexHandlerTest.testAddOtherIndexForForwardIndexDisabledColumn -- Time elapsed: 0.184 s <<< FAILURE!
java.lang.AssertionError: did not expect [1000] but found [1000]
	at org.testng.Assert.fail(Assert.java:111)
	at org.testng.Assert.failEquals(Assert.java:1582)
	at org.testng.Assert.assertNotEqualsImpl(Assert.java:157)
	at org.testng.Assert.assertNotEquals(Assert.java:2201)
	at org.testng.Assert.assertNotEquals(Assert.java:2223)
	at org.apache.pinot.segment.local.segment.index.loader.ForwardIndexHandlerTest.testAddOtherIndexForForwardIndexDisabledColumn(ForwardIndexHandlerTest.java:1957)

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.94%. Comparing base (59551e4) to head (890b077).
Report is 1414 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14580      +/-   ##
============================================
+ Coverage     61.75%   63.94%   +2.18%     
- Complexity      207     1570    +1363     
============================================
  Files          2436     2683     +247     
  Lines        133233   147335   +14102     
  Branches      20636    22587    +1951     
============================================
+ Hits          82274    94207   +11933     
- Misses        44911    46178    +1267     
- Partials       6048     6950     +902     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.91% <ø> (+2.20%) ⬆️
java-21 63.83% <ø> (+2.21%) ⬆️
skip-bytebuffers-false 63.93% <ø> (+2.18%) ⬆️
skip-bytebuffers-true 63.82% <ø> (+36.09%) ⬆️
temurin 63.94% <ø> (+2.18%) ⬆️
unittests 63.93% <ø> (+2.18%) ⬆️
unittests1 55.53% <ø> (+8.64%) ⬆️
unittests2 34.60% <ø> (+6.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang force-pushed the fix_flaky_forward_index_test branch from 865aa31 to 890b077 Compare December 2, 2024 23:23
@Jackie-Jiang Jackie-Jiang merged commit af6fd6c into apache:master Dec 3, 2024
21 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_flaky_forward_index_test branch December 3, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants