Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include column name for v4 raw fwd index build failure #14613

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

itschrispeck
Copy link
Collaborator

It's useful to know which column caused the build failure so it may be addressed more quickly by operators. Currently users are left to guess which column caused the exception.

_dataBuffer.getFile() output is in the format: column_name.sv.raw.fwd

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.05%. Comparing base (59551e4) to head (ecac283).
Report is 1437 commits behind head on master.

Files with missing lines Patch % Lines
.../writer/impl/VarByteChunkForwardIndexWriterV4.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14613      +/-   ##
============================================
+ Coverage     61.75%   64.05%   +2.29%     
- Complexity      207     1572    +1365     
============================================
  Files          2436     2687     +251     
  Lines        133233   147785   +14552     
  Branches      20636    22648    +2012     
============================================
+ Hits          82274    94657   +12383     
- Misses        44911    46196    +1285     
- Partials       6048     6932     +884     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 64.03% <50.00%> (+2.32%) ⬆️
java-21 63.91% <50.00%> (+2.28%) ⬆️
skip-bytebuffers-false 64.04% <50.00%> (+2.29%) ⬆️
skip-bytebuffers-true 63.89% <50.00%> (+36.16%) ⬆️
temurin 64.05% <50.00%> (+2.29%) ⬆️
unittests 64.04% <50.00%> (+2.29%) ⬆️
unittests1 56.19% <50.00%> (+9.30%) ⬆️
unittests2 34.58% <50.00%> (+6.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashmayya yashmayya merged commit dafb4f0 into apache:master Dec 6, 2024
21 checks passed
davecromberge pushed a commit to davecromberge/pinot that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants