Safeguard AbstractBuilder copy constructor from empty TextIndexConfig #14616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14616 +/- ##
============================================
+ Coverage 61.75% 64.03% +2.28%
- Complexity 207 1571 +1364
============================================
Files 2436 2687 +251
Lines 133233 147788 +14555
Branches 20636 22651 +2015
============================================
+ Hits 82274 94641 +12367
- Misses 44911 46215 +1304
- Partials 6048 6932 +884
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
swaminathanmanish
approved these changes
Dec 6, 2024
...ent-local/src/test/java/org/apache/pinot/segment/local/segment/store/TextIndexUtilsTest.java
Show resolved
Hide resolved
davecromberge
pushed a commit
to davecromberge/pinot
that referenced
this pull request
Dec 10, 2024
…apache#14616) * Safeguard AbstractBuilder copy constructor from empty TextIndexConfig * using false as default as LuceneTextIndexReader also has a false default
yashmayya
pushed a commit
to yashmayya/pinot
that referenced
this pull request
Jan 3, 2025
…apache#14616) * Safeguard AbstractBuilder copy constructor from empty TextIndexConfig * using false as default as LuceneTextIndexReader also has a false default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer #13948 (comment)
The PR also fixes the default value of
useANDForMultiTermQuerieswhich was being set totrueviaAbstractBuilder(FSTType fstType)but false when created through json creator onTextIndexConfig()with a json string missing theuseANDForMultiTermQueriesfield. Going with false asLuceneTextIndexReaderalso has a false default for it