Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLPV2_ZSTD and CLPV2_LZ4 raw forward index compression codecs. #14661

Merged

Conversation

jackluo923
Copy link
Contributor

Previously, CLPV2 compression codec defaults to use ZSTD as the chunk compression codec. This PR introduces CLPV2_ZSTD and CLPV2_LZ4 codec which allows user to explicitly select which underlying chunk compression codec to use within CLPV2 immutable forward index.

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.03%. Comparing base (59551e4) to head (8bce73d).
Report is 1470 commits behind head on master.

Files with missing lines Patch % Lines
...ment/index/forward/ForwardIndexCreatorFactory.java 0.00% 2 Missing and 2 partials ⚠️
.../local/segment/index/forward/ForwardIndexType.java 0.00% 0 Missing and 3 partials ⚠️
...ent/creator/impl/fwd/CLPForwardIndexCreatorV2.java 0.00% 2 Missing ⚠️
...he/pinot/segment/local/utils/TableConfigUtils.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14661      +/-   ##
============================================
+ Coverage     61.75%   64.03%   +2.28%     
- Complexity      207     1605    +1398     
============================================
  Files          2436     2700     +264     
  Lines        133233   148817   +15584     
  Branches      20636    22803    +2167     
============================================
+ Hits          82274    95295   +13021     
- Misses        44911    46522    +1611     
- Partials       6048     7000     +952     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 64.00% <23.07%> (+2.29%) ⬆️
java-21 63.92% <23.07%> (+2.29%) ⬆️
skip-bytebuffers-false 64.02% <23.07%> (+2.28%) ⬆️
skip-bytebuffers-true 63.89% <23.07%> (+36.16%) ⬆️
temurin 64.03% <23.07%> (+2.28%) ⬆️
unittests 64.03% <23.07%> (+2.28%) ⬆️
unittests1 56.29% <23.07%> (+9.40%) ⬆️
unittests2 34.46% <23.07%> (+6.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deemoliu deemoliu merged commit b787ad4 into apache:master Jan 13, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants