Add more arithmetic scalar functions #14671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14671 +/- ##
============================================
+ Coverage 61.75% 63.98% +2.23%
- Complexity 207 1605 +1398
============================================
Files 2436 2703 +267
Lines 133233 148938 +15705
Branches 20636 22819 +2183
============================================
+ Hits 82274 95304 +13030
- Misses 44911 46639 +1728
- Partials 6048 6995 +947
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yashmayya
reviewed
Dec 17, 2024
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArithmeticFunctions.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
more-arithmetic-functions
branch
from
4fa8ce6 to
41370e2
Compare
Jackie-Jiang
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new scalar functions to the
ArithmeticFunctionsclass inpinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArithmeticFunctions.java. These functions aim to enhance the mathematical operations available in the codebase, providing more robust and versatile arithmetic capabilities.New scalar functions added:
intDivandintDivOrZero: Perform integer division, withintDivOrZeroreturning zero for division by zero or when dividing a minimal negative number by minus one.isFinite,isInfinite, andisNaN: Check if a double value is finite, infinite, or NaN, respectively.ifNotFinite: Returns a default value if the given value is not finite.moduloOrZeroandpositiveModulo: Variants of the modulo operation, withmoduloOrZeroreturning zero for division by zero or when dividing a minimal negative number by minus one.negate: Returns the negation of a double value.gcdandlcm: Calculate the greatest common divisor and least common multiple of two long values, respectively.hypot: Computes the hypotenuse of a right-angled triangle given the lengths of the other two sides.byteswapIntandbyteswapLong: Perform byte swapping on integer and long values.