Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add icons and shortcuts for query submit and format #14697

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

jadami10
Copy link
Contributor

this is a small ui feature to put shortcuts for UI buttons with the buttons. It should be different for mac vs non-mac.

image

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.05%. Comparing base (59551e4) to head (aaf6e38).
Report is 1496 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14697      +/-   ##
============================================
+ Coverage     61.75%   64.05%   +2.30%     
- Complexity      207     1607    +1400     
============================================
  Files          2436     2706     +270     
  Lines        133233   149200   +15967     
  Branches      20636    22873    +2237     
============================================
+ Hits          82274    95568   +13294     
- Misses        44911    46619    +1708     
- Partials       6048     7013     +965     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 64.03% <ø> (+2.32%) ⬆️
java-21 63.87% <ø> (+2.25%) ⬆️
skip-bytebuffers-false 64.05% <ø> (+2.30%) ⬆️
skip-bytebuffers-true 56.12% <ø> (+28.39%) ⬆️
temurin 64.05% <ø> (+2.30%) ⬆️
unittests 64.04% <ø> (+2.30%) ⬆️
unittests1 56.31% <ø> (+9.42%) ⬆️
unittests2 34.49% <ø> (+6.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang added feature ui UI related issue labels Dec 25, 2024
@Jackie-Jiang Jackie-Jiang merged commit e98389d into apache:master Dec 25, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ui UI related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants