-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add group by trimming to MSQE/V2 query engine #14727
Open
bziobrowski
wants to merge
9
commits into
apache:master
Choose a base branch
from
bziobrowski:group_by_trim_v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14727 +/- ##
============================================
+ Coverage 61.75% 63.84% +2.09%
- Complexity 207 1609 +1402
============================================
Files 2436 2704 +268
Lines 133233 151088 +17855
Branches 20636 23342 +2706
============================================
+ Hits 82274 96463 +14189
- Misses 44911 47393 +2482
- Partials 6048 7232 +1184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/logical/PinotLogicalAggregate.java # pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotAggregateExchangeNodeInsertRule.java # pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/AggregateNode.java # pinot-query-planner/src/test/resources/queries/GroupByPlans.json # pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/server/ServerPlanRequestVisitor.java # pinot-query-runtime/src/test/resources/queries/QueryHints.json
gortiz
reviewed
Jan 2, 2025
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
Outdated
Show resolved
Hide resolved
gortiz
reviewed
Jan 7, 2025
pinot-controller/src/main/java/org/apache/pinot/controller/helix/ControllerRequestClient.java
Show resolved
Hide resolved
gortiz
reviewed
Jan 7, 2025
...on-tests/src/test/java/org/apache/pinot/integration/tests/GroupByOptionsIntegrationTest.java
Outdated
Show resolved
Hide resolved
gortiz
reviewed
Jan 7, 2025
...t-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java
Outdated
Show resolved
Hide resolved
gortiz
reviewed
Jan 7, 2025
...t-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java
Show resolved
Hide resolved
gortiz
reviewed
Jan 7, 2025
...runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultistageGroupByExecutor.java
Show resolved
Hide resolved
gortiz
reviewed
Jan 8, 2025
...runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultistageGroupByExecutor.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds following to MSQE engine:
group_trim_size
hint - that enables trimming at aggregate operator stage if both order by and limit are available (currently requires usingis_enable_group_trim
hint). Note:is_enable_group_trim
also enables v1-style leaf-stage group by results trimming. See grouping algorithm documentation for details.error_or_num_groups_limit
hint orerrorOnNumGroupsLimit
query option - throws exception when num_groups_limit is reached in aggregate operator instead of setting a metadata flagExamples:
Query:
Execution plan:
Query:
Execution plan:
cc @Jackie-Jiang @gortiz