Remove segment level warning logging for TimeSegmentPruner #14855
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14855 +/- ##
============================================
+ Coverage 61.75% 63.72% +1.97%
- Complexity 207 1612 +1405
============================================
Files 2436 2708 +272
Lines 133233 151315 +18082
Branches 20636 23359 +2723
============================================
+ Hits 82274 96429 +14155
- Misses 44911 47644 +2733
- Partials 6048 7242 +1194
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
approved these changes
Jan 21, 2025
xiangfu0
force-pushed
the
fixing_time_pruner_log
branch
from
e8213a5 to
f1571ff
Compare
xiangfu0
changed the title
zeronerdzerogeekzerocool
pushed a commit
to zeronerdzerogeekzerocool/pinot
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove segment level warning logging for TimeSegmentPruner.
For table with many kafka partitions, the broker log is flushed with warning message:
Failed to find valid time interval for segment: xxx__101__1551__20250121T1744Z, table: xxx_REALTIME