Revert setCatalogType(INTERNAL) test changes

Author: poojanilangekar

runtime/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisAdminServiceAuthzTest.java

@@ -132,8 +132,7 @@ public void testCreateCatalogSufficientPrivileges() {
             adminService.grantPrivilegeOnRootContainerToPrincipalRole(
                 PRINCIPAL_ROLE2, PolarisPrivilege.CATALOG_DROP))
         .isTrue();
-    final CatalogEntity newCatalog =
-        new CatalogEntity.Builder().setName("new_catalog").setCatalogType("INTERNAL").build();
+    final CatalogEntity newCatalog = new CatalogEntity.Builder().setName("new_catalog").build();
     final CreateCatalogRequest createRequest = new CreateCatalogRequest(newCatalog.asCatalog());
 
     doTestSufficientPrivileges(
@@ -152,8 +151,7 @@ public void testCreateCatalogSufficientPrivileges() {
 
   @Test
   public void testCreateCatalogInsufficientPrivileges() {
-    final CatalogEntity newCatalog =
-        new CatalogEntity.Builder().setName("new_catalog").setCatalogType("INTERNAL").build();
+    final CatalogEntity newCatalog = new CatalogEntity.Builder().setName("new_catalog").build();
     final CreateCatalogRequest createRequest = new CreateCatalogRequest(newCatalog.asCatalog());
 
     doTestInsufficientPrivileges(
@@ -289,8 +287,7 @@ public void testDeleteCatalogSufficientPrivileges() {
             adminService.grantPrivilegeOnRootContainerToPrincipalRole(
                 PRINCIPAL_ROLE2, PolarisPrivilege.CATALOG_CREATE))
         .isTrue();
-    final CatalogEntity newCatalog =
-        new CatalogEntity.Builder().setName("new_catalog").setCatalogType("INTERNAL").build();
+    final CatalogEntity newCatalog = new CatalogEntity.Builder().setName("new_catalog").build();
     final CreateCatalogRequest createRequest = new CreateCatalogRequest(newCatalog.asCatalog());
     adminService.createCatalog(createRequest);
 
@@ -310,8 +307,7 @@ public void testDeleteCatalogSufficientPrivileges() {
 
   @Test
   public void testDeleteCatalogInsufficientPrivileges() {
-    final CatalogEntity newCatalog =
-        new CatalogEntity.Builder().setName("new_catalog").setCatalogType("INTERNAL").build();
+    final CatalogEntity newCatalog = new CatalogEntity.Builder().setName("new_catalog").build();
     final CreateCatalogRequest createRequest = new CreateCatalogRequest(newCatalog.asCatalog());
     adminService.createCatalog(createRequest);
 

runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java

@@ -345,7 +345,6 @@ public void before(TestInfo testInfo) {
             new CreateCatalogRequest(
                 new CatalogEntity.Builder()
                     .setName(CATALOG_NAME)
-                    .setCatalogType("INTERNAL")
                     .setDefaultBaseLocation(storageLocation)
                     .setReplaceNewLocationPrefixWithCatalogDefault("file:")
                     .addProperty(
@@ -1358,7 +1357,6 @@ public void testUpdateNotificationCreateTableWithLocalFilePrefix() {
                 new CatalogEntity.Builder()
                     .setDefaultBaseLocation("file://")
                     .setName(catalogWithoutStorage)
-                    .setCatalogType("INTERNAL")
                     .build()
                     .asCatalog()));
 
@@ -1424,7 +1422,6 @@ public void testUpdateNotificationCreateTableWithHttpPrefix() {
             new CatalogEntity.Builder()
                 .setDefaultBaseLocation("http://maliciousdomain.com")
                 .setName(catalogName)
-                .setCatalogType("INTERNAL")
                 .build()
                 .asCatalog()));
 
@@ -1954,7 +1951,6 @@ public void testDropTableWithPurgeDisabled() {
         new CreateCatalogRequest(
             new CatalogEntity.Builder()
                 .setName(noPurgeCatalogName)
-                .setCatalogType("INTERNAL")
                 .setDefaultBaseLocation(storageLocation)
                 .setReplaceNewLocationPrefixWithCatalogDefault("file:")
                 .addProperty(
@@ -2272,7 +2268,6 @@ public void createCatalogWithReservedProperty() {
                       new CatalogEntity.Builder()
                           .setDefaultBaseLocation("file://")
                           .setName("createCatalogWithReservedProperty")
-                          .setCatalogType("INTERNAL")
                           .setProperties(ImmutableMap.of("polaris.reserved", "true"))
                           .build()
                           .asCatalog()));
@@ -2288,7 +2283,6 @@ public void updateCatalogWithReservedProperty() {
             new CatalogEntity.Builder()
                 .setDefaultBaseLocation("file://")
                 .setName("updateCatalogWithReservedProperty")
-                .setCatalogType("INTERNAL")
                 .setProperties(ImmutableMap.of("a", "b"))
                 .build()
                 .asCatalog()));

runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogViewTest.java

@@ -217,7 +217,6 @@ public void before(TestInfo testInfo) {
         new CreateCatalogRequest(
             new CatalogEntity.Builder()
                 .setName(CATALOG_NAME)
-                .setCatalogType("INTERNAL")
                 .addProperty(
                     FeatureConfiguration.ALLOW_EXTERNAL_TABLE_LOCATION.catalogConfig(), "true")
                 .addProperty(

runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/PolarisGenericTableCatalogTest.java

@@ -224,7 +224,6 @@ public void before(TestInfo testInfo) {
             new CreateCatalogRequest(
                 new CatalogEntity.Builder()
                     .setName(CATALOG_NAME)
-                    .setCatalogType("INTERNAL")
                     .setDefaultBaseLocation(storageLocation)
                     .setReplaceNewLocationPrefixWithCatalogDefault("file:")
                     .addProperty(

runtime/service/src/test/java/org/apache/polaris/service/quarkus/catalog/PolicyCatalogTest.java

@@ -252,7 +252,6 @@ public void before(TestInfo testInfo) {
             new CreateCatalogRequest(
                 new CatalogEntity.Builder()
                     .setName(CATALOG_NAME)
-                    .setCatalogType("INTERNAL")
                     .setDefaultBaseLocation(storageLocation)
                     .setReplaceNewLocationPrefixWithCatalogDefault("file:")
                     .addProperty(