Gradle tweaks #10
Merged
Gradle tweaks #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
snazy
commented
Jul 30, 2024
snazy
commented
- configure-on-demand
- replace usages of deprecated Gradle APIs
eric-maynard
pushed a commit
to eric-maynard/polaris
that referenced
this pull request
Jul 30, 2024
…licit properties (apache#10) * Fix log format to include key-value pairs from autogenerated stubs logging request params. * Split out a CallContext that is distinct from RealmContext and make the interfaces more explicit for now to be clear about what we expect to parse for each one. Define a convention for parsing realm, user, and role out from the bearer token for testing purposes.
eric-maynard
pushed a commit
to eric-maynard/polaris
that referenced
this pull request
Jul 30, 2024
Pull polaris OSS repository as subtree
build.gradle
Outdated
| project(":polaris-core") { | ||
| apply plugin: "java-library" | ||
| } | ||
| // Note: polaris-core seemed to be for Java 11, but uses functions that are introduced in later Java versions |
There was a problem hiding this comment.
then shouldn't we just change the version? I'm confused why we would have this workaround?
|
I really think we should break this one into separate PR's. The posfix -> . refactor I think is good but we are also doing a bunch of other things here. |
* configure-on-demand * replace usages of deprecated Gradle APIs
snazy
force-pushed
the
gradle-adoptions
branch
2 times, most recently
from
85bb9d1
to
2f4151b
Compare
That's all for the "replace deprecated Gradle API" part ( |
|
|
||
| project(":polaris-service") { | ||
| apply plugin: "application" |
There was a problem hiding this comment.
For my own reference, Plugin specification is moved into project specific build files.
RussellSpitzer
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.