Add logging and move test to the right package #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aihuaxu
force-pushed
the
aixu-add-logs-reuse-factory
branch
from
6c0a9a2 to
c7bbb3d
Compare
aihuaxu
commented
Aug 7, 2024
| @@ -146,16 +164,24 @@ private EntityManagerFactory createEntityManagerFactory( | |||
| properties.put(ECLIPSELINK_PERSISTENCE_XML, confFile); | |||
|
|
|||
| return Persistence.createEntityManagerFactory(persistenceUnitName, properties); | |||
| } catch (Exception e) { | |||
| } catch (IOException e) { | |||
There was a problem hiding this comment.
@collado-mike Didn't get your original comment "catch RuntimeException separately and just rethrow".
aihuaxu
changed the title
… for different realm
aihuaxu
force-pushed
the
aixu-add-logs-reuse-factory
branch
from
cb23532 to
c6f41a9
Compare
aihuaxu
changed the title
flyrain
reviewed
Aug 7, 2024
Comment on lines
64
to
65
| // Clear to test out EntityManagerFactory creation, otherwise cached EntityManagerFactory would | ||
| // get reused |
There was a problem hiding this comment.
minor suggestion: -> Clear cache to prevent reuse
| @@ -82,6 +84,10 @@ public class PolarisEclipseLinkMetaStoreSessionImpl implements PolarisMetaStoreS | |||
| private static final Logger LOG = | |||
| LoggerFactory.getLogger(PolarisEclipseLinkMetaStoreSessionImpl.class); | |||
|
|
|||
| // Cache to hold the EntityManagerFactory for each realm. Each realm needs a separate | |||
| // EntityManagerFactory since it connects to different databases | |||
| private static ConcurrentHashMap<String, EntityManagerFactory> realmFactories = | |||
There was a problem hiding this comment.
-> static final as we don't want any object of this class to reassign a new realmFactories
| */ | ||
| private EntityManagerFactory createEntityManagerFactory( | ||
| @NotNull RealmContext realmContext, | ||
| @Nullable String confFile, | ||
| @Nullable String persistenceUnitName) { | ||
| String realm = realmContext.getRealmIdentifier(); | ||
| EntityManagerFactory factory = | ||
| realmFactories.getOrDefault(realmContext.getRealmIdentifier(), null); |
There was a problem hiding this comment.
minor: realmContext.getRealmIdentifier() -> realm
@flyrain Thanks for reviewing. Updated based on the comments. Each realm communicates with its dedicated database and doesn't change. For now, I don't see the cases which we need to invalidate it. |
eric-maynard
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the logging and also move the PolarisEclipseLinkMetaStoreTest.java since it's in incorrect package.
Fixes #45
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Please delete options that are not relevant.