Add logging and move test to the right package #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aihuaxu
force-pushed
the
aixu-add-logs-reuse-factory
branch
from
6c0a9a2 to
c7bbb3d
Compare
aihuaxu
commented
Aug 7, 2024
|
|
||
| return Persistence.createEntityManagerFactory(persistenceUnitName, properties); | ||
| } catch (Exception e) { | ||
| } catch (IOException e) { |
Contributor
Author
There was a problem hiding this comment.
@collado-mike Didn't get your original comment "catch RuntimeException separately and just rethrow".
aihuaxu
changed the title
… for different realm
aihuaxu
force-pushed
the
aixu-add-logs-reuse-factory
branch
from
cb23532 to
c6f41a9
Compare
aihuaxu
changed the title
flyrain
reviewed
Aug 7, 2024
Comment on lines
64
to
65
| // Clear to test out EntityManagerFactory creation, otherwise cached EntityManagerFactory would | ||
| // get reused |
Contributor
There was a problem hiding this comment.
minor suggestion: -> Clear cache to prevent reuse
|
|
||
| // Cache to hold the EntityManagerFactory for each realm. Each realm needs a separate | ||
| // EntityManagerFactory since it connects to different databases | ||
| private static ConcurrentHashMap<String, EntityManagerFactory> realmFactories = |
Contributor
There was a problem hiding this comment.
-> static final as we don't want any object of this class to reassign a new realmFactories
| @Nullable String persistenceUnitName) { | ||
| String realm = realmContext.getRealmIdentifier(); | ||
| EntityManagerFactory factory = | ||
| realmFactories.getOrDefault(realmContext.getRealmIdentifier(), null); |
Contributor
There was a problem hiding this comment.
minor: realmContext.getRealmIdentifier() -> realm
Contributor
Author
@flyrain Thanks for reviewing. Updated based on the comments. Each realm communicates with its dedicated database and doesn't change. For now, I don't see the cases which we need to invalidate it. |
eric-maynard
approved these changes
Aug 7, 2024
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
* Fix Keycloak getting-started example (apache#2349) The `polaris-setup` container was erroneously including a non-existent scope when fetching a token from Keycloak. * fix(deps): update dependency com.nimbusds:nimbus-jose-jwt to v10.4.2 (apache#2350) * Use PolarisTaskConstants (apache#2346) * Add a regression test for Catalog Federation (apache#2286) * Add a regression test for Catalog Federation * Install jq dependency * Fix token issues * Update regtests/README.md Co-authored-by: Eric Maynard <emaynard@apache.org> * Update README.md --------- Co-authored-by: Eric Maynard <emaynard@apache.org> * Modularize federation (Option 2) (apache#2332) * Modularize federation (Option 2) * Move polaris-extensions-federation-hadoop dependency * Change identifier to lowerCase * Change identifiers to constants * Replace CallContext with RealmConfig in enforceFeatureEnabledOrThrow (apache#2348) * Replace CallContext with RealmConfig in CatalogEntity (apache#2336) * chore(deps): update registry.access.redhat.com/ubi9/openjdk-21-runtime docker tag to v1.23-6 (apache#2353) * fix(deps): update dependency com.gradleup.shadow:shadow-gradle-plugin to v9.0.2 (apache#2358) * chore(deps): update postgres docker tag to v17.6 (apache#2354) * Add integration tests with Keycloak (apache#2343) * Fix REST responses for failed Admin operations (apache#2291) * Fix REST responses for failed Admin operations the `boolean` return values of many methods in `PolarisAdminService` were often simply not getting used at all, thus the REST api returned success in those cases even though the `PrivilegeResult` was marked as failed. due to this fix a silently failing test now needs to be adjusted. we return the `PrivilegeResult` instead of a `boolean` to give the client at least some indication of what has gone wrong on the server side. note that some of the other operations were throwing Expcetions already, which are already reported back correctly to the client. * review: use http 400 BAD_REQUEST * Make PolarisAuthorizer RequestScoped (apache#2340) all methods in `PolarisAuthorizer` currently have a `CallContext` parameter. in its only implementation only `CallContext.getRealmConfig` is getting used. so since `PolarisAuthorizer` cant be used outside a request, we can simply make it request-scoped and inject the request-scoped `RealmConfig` directly. * fix(deps): update mockito monorepo to v5.19.0 (apache#2360) * Fix soft-merge conflict on `main` (apache#2364) * feat(docs): Add Getting Stated guide for MinIO (apache#2227) * feat(docs): Add Getting Stated guide for MinIO A simple page of step-by-step instructions for setting up a local environment with Polaris, MinIO and Spark. Closes apache#1530 * IntelliJ: fix project icon in IJ project list (apache#2366) ... copy source has changed * Use asMap property helpers (apache#2347) seems like these helpers existed for a long time but were just not getting used consistently * SigV4 Auth Support for Catalog Federation - Part 2: Connection Config Persistence (apache#2190) * Add SigV4 related DPOs * Rename UserSecretReference to SecretReference and fix some small issues * fix(deps): update dependency software.amazon.awssdk:bom to v2.32.24 (apache#2371) * Rat-check: exclude venv, cleanup excludes, include .svg (apache#2363) * `.svg` files are XML files and can contain a license header * Re-grouped the exclusion rat patterns * Added exclude for `.venv` * Added exclude for `.ruff_cache` * NoSQL: Async-impls: add some safeguards + javadoc spelling * NoSQL: spelling * NoSQL: dependency updates * Last merged commit: 5a7686b --------- Co-authored-by: Alexandre Dutra <adutra@apache.org> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Christopher Lambert <xn137@gmx.de> Co-authored-by: Pooja Nilangekar <nilangekar.pooja@gmail.com> Co-authored-by: Eric Maynard <emaynard@apache.org> Co-authored-by: Dmitri Bourlatchkov <dmitri.bourlatchkov@gmail.com> Co-authored-by: Rulin Xing <xjdkcsq3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the logging and also move the PolarisEclipseLinkMetaStoreTest.java since it's in incorrect package.
Fixes #45
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Please delete options that are not relevant.