Skip to content

Conversation

@haizhou-zhao
Copy link
Contributor

Description

There's a typo in top level gradle build script preventing gradle plugin indexing in IDE (intellij).

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Indexing the project in Intellij.

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:
  • IDE version: IntelliJ IDEA 2024.1.1 (Community Edition)

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue
  • I have signed and submitted the ICLA and if needed, the CCLA. See Contributing for details.

@haizhou-zhao haizhou-zhao requested a review from a team as a code owner August 7, 2024 20:31
Copy link
Contributor

@flyrain flyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thank @haizhou-zhao for the fix.

@snazy
Copy link
Member

snazy commented Aug 7, 2024

This damn copy&paste :disappear: (my bad)

@flyrain flyrain merged commit 8f6f733 into apache:main Aug 7, 2024
@flyrain
Copy link
Contributor

flyrain commented Aug 7, 2024

Thanks @haizhou-zhao for the fix and @snazy for the review, this unblocks the IDE build.

snazy added a commit to snazy/polaris that referenced this pull request Nov 20, 2025
* Update dependency io.netty:netty-codec-http2 to v4.2.6.Final (apache#2520)

* Update dependency org.testcontainers:localstack to v1.21.3 (apache#2497)

* Allow overriding createCatalog calls in integrations tests (apache#2516)

This is mostly to add testing flexibility in downstream projects.

* Allow `PolarisServerManager` implementations to define custom client headers (apache#2510)

`PolarisServerManager` is a plugin point for downstream builds
to define runtime env. for tests under `integration-tests`.

This change allows more flexibility for test runtime environments
by allowing injecting extra headers into test clients.

* Fix deprecation warnings around RandomStringUtils (apache#2507)

the `RandomStringUtils.random` method is deprecated since commons-lang 3.17.0

apache/commons-lang@69cb996

* Add support for poetry build with wheel (apache#2425)

* Core: Clarify the purpose of REPLACE_NEW_LOCATION_PREFIX_WITH_CATALOG_DEFAULT_KEY (apache#2509)

* Update gradle/actions digest to ed40850 (apache#2524)

* Update dependency com.fasterxml.jackson:jackson-bom to v2.20.0 (apache#2470)

* Update hadoop to v3.4.2 (apache#2466)

* Last merged commit a1d1176

---------

Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: Dmitri Bourlatchkov <dmitri.bourlatchkov@gmail.com>
Co-authored-by: Christopher Lambert <xn137@gmx.de>
Co-authored-by: Yong Zheng <yongzheng0809@gmail.com>
Co-authored-by: Yufei Gu <yufei@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants