-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing changes for eclipselink #118
Conversation
@snazy @collado-mike maybe duplicated of #114 as the change was intensional? But "implementation(libs.h2)" is still needed to add h2 lib for default persistent backend. |
@@ -90,7 +90,7 @@ defaultRealms: | |||
metaStoreManager: | |||
type: in-memory | |||
# type: eclipse-link # uncomment to use eclipse-link as metastore | |||
# persistence-unit: polaris |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally keep this to be polaris rather than polaris-dev. polaris-dev is used in test and polaris is used for production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, if we have persistence.xml from test resource and production resource, we are loading the one from test resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Let me revert this one...but I don't think we will need this PR as the change is intensional based off https://github.com/polaris-catalog/polaris/pull/114/files. I think the only thing that is missing there is h2 lib import. Let me close this one and use 114 to add that in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@collado-mike close this one and added comment in your PR for including h2 lib if people ant to use default persist backend with h2.
Description
Seems like some changes got missing after switch from build logic from Groovy to Kotlin
Fixes 47
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Same as #47
Checklist:
Please delete options that are not relevant.