Rename setup.sh to run.sh #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"setup" can be misunderstood as build-related. Rename the script to avoid confusion. Also add a line of comment what the script does for readers who didn't read (or didn't remember) all of the README.
Contributor
|
Thanks @findepi for the change. I was thinking about the same same. What about a more descriptive name like |
Member
Author
|
i would use "deploy" if the intent of the script is to deploy to some existing production grade k8s cluster. |
Contributor
|
I don't have strong opinion on it. I agreed that |
flyrain
approved these changes
Aug 8, 2024
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
* docs(README): Create Polaris-Core README (apache#2585) * docs(README): Create Polaris-Core README * Add Events for Iceberg REST APIs (apache#2480) * Update dependency com.google.guava:guava to v33.5.0-jre (apache#2601) * Bump: Iceberg client in tests and documentation to 1.10 (apache#2588) * Add client build to Gradle (apache#2590) * Add client build to Gradle * Add overwrite option for python build * Match client build behavior * Add content to contributing guidelines. (apache#2536) Add community guidelines. * CI/Caching: Fix Gradle cache retention (apache#2604) Older versions of Gradle's setup-gradle action did not actively trigger stale cache entry cleanup, which is why there was a separate step "Trigger Gradle home cleanup" in `gradle.yml`. Nowadays, that action triggers a "noop build" to explicitly trigger stale cache entry cleanup, but uses somewhat different defaults than [described here](https://docs.gradle.org/current/userguide/directory_layout.html#dir:gradle_user_home:configure_cache_cleanup). This change adds an explicit configuration for Gradle cache cleanup/retention with reasonable values considering the total 10GB limit for all GitHub caches per repository. The change described above lead to a behavioral change, which evicts all non-accessed cache entries within the current GH workflow job, which effectively evicted all cache entries from dependent jobs - in other words: the (build) cache was nearly empty, leading to full rebuilds. This behavior could be observed in the output of the "Post Collect partial Gradle build caches"-step in the log message "Build cache (/home/runner/.gradle/caches/build-cache-1) removing files not accessed on or after ..." showing the timestamp when the setup-gradle action was started. * Last merged commit d8602f6 --------- Co-authored-by: Adam Christian <105929021+adam-christian-software@users.noreply.github.com> Co-authored-by: Adnan Hemani <adnan.h@berkeley.edu> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Prashant Singh <35593236+singhpk234@users.noreply.github.com> Co-authored-by: Yong Zheng <yongzheng0809@gmail.com> Co-authored-by: JB Onofré <jbonofre@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"setup" can be misunderstood as build-related. Rename the script to avoid confusion. Also add a line of comment what the script does for readers who didn't read (or didn't remember) all of the README.